From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C6DE14A0A4 for ; Thu, 11 Apr 2024 12:01:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712836922; cv=none; b=GKHtzs+M+1IKwaMbFUslE2a9prNdYGk76Aj6TikUkrlWMerbHewgSAxNttAPbhFzu3924kSRZ93g1/VhocG4Pkns/q70/89hFrxxa6dEDE+Ynf5p2+4CsmD0nQx6/t3ZRGkognvXcZS+XM1kd3pX/bVAhQn7lwnAGqAW6HzH1Rc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712836922; c=relaxed/simple; bh=doOhwiBjpxxQqY1rLrcrBqjVSCV6vzFMDlK3AJSyZz8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Y90wMXnfbA3H9fP7bL6bggcOXzpQnKx7rHbnhbvtJE0UZCvclGjWOUOd8I7cosZAND6/rGyQCSASy5BBatxaPG7H7R9XtI51nO0JK1VR2+kkz5fGoskdfijxyVhcUhvfUwE4Yz/sJFyj7+MEawyX+5BSXAXoHwAd5fZNYeBjIaw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nexus-software.ie; spf=none smtp.mailfrom=nexus-software.ie; dkim=pass (2048-bit key) header.d=nexus-software-ie.20230601.gappssmtp.com header.i=@nexus-software-ie.20230601.gappssmtp.com header.b=Vy41shpt; arc=none smtp.client-ip=209.85.208.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nexus-software.ie Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=nexus-software.ie Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nexus-software-ie.20230601.gappssmtp.com header.i=@nexus-software-ie.20230601.gappssmtp.com header.b="Vy41shpt" Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2d895138ce6so51908501fa.0 for ; Thu, 11 Apr 2024 05:01:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexus-software-ie.20230601.gappssmtp.com; s=20230601; t=1712836918; x=1713441718; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uwD98CwQhR7Q3CQUV5z/ptQ0GppSR1Tt0Ic2tF4GPa0=; b=Vy41shptEKfU5rCAyH+3FZAL8D8PLEiJTcwl3inQUK1eQCHT2Ak7pvx9Lp8ImtbWv9 AmD5kh3pNIVHeVnu2tghHGdjCXbxROAcx8AhSPLPEaDCAOqFtmaIQnfY5zNpk1gpyi87 Fic19HkC2LoQVXRfpSCdGVz7nMy1xmMgMDRtufH/RSlgLNV57gv/GH0B4oVbJaNIKMbQ tTIBwpamKEyGaqYcxsZgJUy/bMs4Bk5ucCKLSwN6ZMo9I/0YtXDPojiez9Vr7+IoS3OE U4EyCkZOAjqG093+X5eQejtbOcPOqSXqdevL7/GsPYT42RJLABwkesHCI9i7qEg7iBP+ cTOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712836918; x=1713441718; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uwD98CwQhR7Q3CQUV5z/ptQ0GppSR1Tt0Ic2tF4GPa0=; b=LXY+wSIqQ+f3z7e3Ahxt8aIZxHt4L3EuPXTOU6w1qPK9NdiUz7Dm39Vi1xYBE2EYIl CLz81jSRN/E9AmntU9Sjn85NVvpuhhxQtTgS7cXlGIAt5dF8hx3FRoJSpe3kka4gjRSN ZakTr9mHUaKlN7vuKBAlZQ25e2ZFF3Pt82vtiSZBkLrpOso63t0qVC+kRI9z0R0Y4jOw /PRu+Rhrq0+jTKHZXegyn1DmcYTqkRHFckk7zwJIJ4Kbow0fuyxYAvlHZypCaq/OVYJP S1Uakl6r+hU9z8DyQ6PxZFFEpZx9dRifEV8BBTSdTi8Y8QLLJnPCveRPp7Mk3QT6xX+Q peQg== X-Forwarded-Encrypted: i=1; AJvYcCWEfZJBhstB/tQxj7rHiBDaGHS5DB0l6GgLekz+Mr057Hqk4lqPy8Ab+oP+IXfMkqGzGEhbfkvPxdSXenqSVrzHLFAVM6fg9oh/ X-Gm-Message-State: AOJu0YygYcAjic34BaMjzPSN+8XIX2ebIs1ebPcQvM6GFTSSMIrE/fhK PeExbpZ0JAJUFd7bSZ5ysiPwLCOL7X0LPsskpn0SNa5riaO1D5lYMJZ/7bt6xmQ= X-Google-Smtp-Source: AGHT+IEurZPeKh17aFb51dEYvQ9h/gbXT4M0UIujnkjMsVpDjMrgk2goKbLwPQw063dBf0HZNY1mSg== X-Received: by 2002:a2e:9d06:0:b0:2d8:9487:7588 with SMTP id t6-20020a2e9d06000000b002d894877588mr3768627lji.38.1712836917974; Thu, 11 Apr 2024 05:01:57 -0700 (PDT) Received: from [192.168.0.102] ([176.61.106.68]) by smtp.gmail.com with ESMTPSA id j24-20020a05600c1c1800b0041643c9cb0dsm5356812wms.42.2024.04.11.05.01.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Apr 2024 05:01:57 -0700 (PDT) Message-ID: Date: Thu, 11 Apr 2024 13:01:56 +0100 Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Revert "Revert "dt-bindings: i2c: qcom-cci: Document sc8280xp compatible"" To: Bryan O'Donoghue , Krzysztof Kozlowski , Vladimir Zapolskiy , Bjorn Andersson , Robert Foss , Loic Poulain , Krzysztof Kozlowski , Konrad Dybcio , Wolfram Sang Cc: Neil Armstrong , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <20240411085218.450237-1-vladimir.zapolskiy@linaro.org> <94779d2c-d159-4429-b0b2-6baa83461bbd@linaro.org> <1b4f745b-67d3-4044-9b89-de6c2c496af5@linaro.org> <7ef1c0e0-bd28-43f1-a46e-4fa551714e82@linaro.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/04/2024 12:57, Bryan O'Donoghue wrote: > On 11/04/2024 11:28, Krzysztof Kozlowski wrote: >> On 11/04/2024 12:24, Bryan O'Donoghue wrote: >>> On 11/04/2024 11:18, Krzysztof Kozlowski wrote: >>>> On 11/04/2024 12:16, Krzysztof Kozlowski wrote: >>>>> On 11/04/2024 12:12, Bryan O'Donoghue wrote: >>>>>> On 11/04/2024 10:36, Krzysztof Kozlowski wrote: >>>>>>> On 11/04/2024 10:52, Vladimir Zapolskiy wrote: >>>>>>>> This reverts commit 3e383dce513f426b7d79c0e6f8afe5d22a581f58. >>>>>>>> >>>>>>>> The commit ae2a1f0f2cb5 ("dt-bindings: i2c: qcom-cci: Document >>>>>>>> sc8280xp compatible") >>>>>>>> was correct apparently, it is required to describe the sc8280xp-cci >>>>>>>> controller properly, as well it eliminates dtbs_check warnings. >>>>>>>> >>>>>>>> Signed-off-by: Vladimir Zapolskiy >>>>>>> >>>>>>> I am lost. Not on your patch, because it looks reasonable, but on >>>>>>> entire >>>>>>> history. >>>>>>> >>>>>>> Can anyone explain me why original commit was reverted? >>>>>>> >>>>>>> https://lore.kernel.org/all/767bc246-a0a0-4dad-badc-81ed50573832@linaro.org/ >>>>>>> >>>>>>> Best regards, >>>>>>> Krzysztof >>>>>>> >>>>>> >>>>>> https://patchwork.ozlabs.org/project/devicetree-bindings/cover/20231006120159.3413789-1-bryan.odonoghue@linaro.org/#3195094 >>>>>> >>>>>> We can you sm8250-cci instead, so dropped the additional compat. >>>>> >>>>> I am sorry, but that links point to cover letter and actually the same >>>>> thread as I linked. What does it prove? >>>>> >>>> >>>> And just to remind because you bring some discussions from driver: we >>>> talk here *only* about bindings patch. Not driver. >>> >>> https://patchwork.ozlabs.org/project/devicetree-bindings/cover/20231006120159.3413789-1-bryan.odonoghue@linaro.org/#3195327 >>> >>> Konrad pointed out we don't need a new compat because the sm8250 compat >>> string could be reused. >> >> Where did he point that? I see only comment about driver, not bindings. >> Please point me to his comment (and again, not patchwork which gives you >> entire discussion and no one knows to which comment you refer, but lore >> link which leads to specific one email where Konrad said it). > > Konrad made a comment about the compat string in the driver, I looked at > the yaml and realised I could reuse the compat string. > > Then asked for a reversion of the add. > > I still think this is the right thing to do, no ? > > --- > bod > OK I see the confusion. I forgot to fix the compat string in the submitted dtsi. commit 7cfa2e758bf4d56e0db5587a88db01ee6fffa259 Author: Bryan O'Donoghue Date: Thu Jan 11 17:15:56 2024 +0000 + cci0: cci@ac4a000 { + compatible = "qcom,sc8280xp-cci" That should be "qcom,sm8250-cci" since there was no need for a separate 8280xp compat string. --- bod