From: Krzysztof Kozlowski <krzk@kernel.org>
To: andi.shyti@kernel.org, linux-i2c@vger.kernel.org,
Hans Hu <HansHu-oc@zhaoxin.com>
Cc: cobechen@zhaoxin.com, TonyWWang@zhaoxin.com
Subject: Re: [PATCH v3] i2c: add support for Zhaoxin I2C controller
Date: Thu, 8 Jun 2023 08:37:13 +0200 [thread overview]
Message-ID: <e5ecb4ca-f56a-b0cd-cd17-eff0277dfd14@kernel.org> (raw)
In-Reply-To: <87c0be06-0ac4-5d34-671c-5668739bdb8b@zhaoxin.com>
On 07/06/2023 14:33, Hans Hu wrote:
>>> +
>>> + i2c = devm_kzalloc(&pdev->dev, sizeof(*i2c), GFP_KERNEL);
>>> + if (IS_ERR(i2c)) {
>>> + return dev_err_probe(&pdev->dev, -ENOMEM,
>>> + "devm_kzalloc failed\n");
>> Don't print ENOMEM.
>
>
> will change to just return -ENOMEM;
>
>
>> Run:
>> 1. Checkpatch
>> 2. Coccinelle
>> to fix trivial issues.
>
>
> I used the checkpatch in different versions of the kernel, and there were
> no errors, just a warning about the modify MAINTAINERS, will modify it.
You did not run Coccinelle/coccicheck, so you have trivial issues in the
code. There is no need for us to manually review something which tools
point out.
Please run Coccinelle/coccicheck and fix all errors.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-08 6:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 5:01 [PATCH v3] i2c: add support for Zhaoxin I2C controller Hans Hu
2023-06-05 14:56 ` Andi Shyti
2023-06-06 6:04 ` Hans Hu
2023-06-06 8:34 ` Krzysztof Kozlowski
2023-06-07 12:33 ` Hans Hu
2023-06-07 13:55 ` Krzysztof Kozlowski
2023-06-08 3:08 ` Hans Hu
2023-06-08 6:37 ` Krzysztof Kozlowski [this message]
2023-06-08 8:50 ` Hans Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5ecb4ca-f56a-b0cd-cd17-eff0277dfd14@kernel.org \
--to=krzk@kernel.org \
--cc=HansHu-oc@zhaoxin.com \
--cc=TonyWWang@zhaoxin.com \
--cc=andi.shyti@kernel.org \
--cc=cobechen@zhaoxin.com \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox