From: Mukesh Savaliya <mukesh.savaliya@oss.qualcomm.com>
To: Aniket Randive <aniket.randive@oss.qualcomm.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Andi Shyti <andi.shyti@kernel.org>,
Dmitry Guzman <Dmitry.Guzman@mobileye.com>
Cc: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>,
linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 2/2] i2c: qcom-geni: Add dynamic transfer timeout based on transfer length and frequency
Date: Mon, 7 Sep 2026 12:54:14 +0530 [thread overview]
Message-ID: <e677e122-8653-4de6-844f-b7ca7154e3c0@oss.qualcomm.com> (raw)
In-Reply-To: <20260827-master-v8-2-596bc81c5cf9@oss.qualcomm.com>
On 8/27/2026 5:57 PM, Aniket Randive wrote:
> The driver uses a static XFER_TIMEOUT of HZ (1 second) for all transfers
> regardless of message length or bus frequency, causing unnecessary
> delays on error paths.
>
> Use i2c_update_timeout() API to calculate transfer timeouts dynamically
> based on message length and bus frequency. update the timeout per message
> for FIFO, SE-DMA and GPI single descriptor transfers. For GPI multi
> descriptor transfers, calculate the timeout from the combined length of
> all messages, as completion is reported only after the entire batch has
> finished.
>
> A 10x safety margin over the theoretical wire time is applied, with a
> 300ms floor to account for I2C clock stretching and other situations where
> a slave may keep SCL asserted for an extended period, including faulty
> devices holding the bus.
>
> Signed-off-by: Aniket Randive <aniket.randive@oss.qualcomm.com>
> ---
Reviewed-by: Mukesh Kumar Savaliya <mukesh.savaliya@oss.qualcomm.com>
next prev parent reply other threads:[~2026-09-07 7:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-27 12:27 [PATCH v8 0/2] i2c: Add dynamic transfer timeout based on message length and frequency Aniket Randive
2026-08-27 12:27 ` [PATCH v8 1/2] i2c: core: Add i2c_update_timeout() helper for dynamic transfer timeouts Aniket Randive
2026-09-07 7:22 ` Mukesh Savaliya
2026-08-27 12:27 ` [PATCH v8 2/2] i2c: qcom-geni: Add dynamic transfer timeout based on transfer length and frequency Aniket Randive
2026-09-07 7:24 ` Mukesh Savaliya [this message]
2026-09-07 7:12 ` [PATCH v8 0/2] i2c: Add dynamic transfer timeout based on message " Mukesh Savaliya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e677e122-8653-4de6-844f-b7ca7154e3c0@oss.qualcomm.com \
--to=mukesh.savaliya@oss.qualcomm.com \
--cc=Dmitry.Guzman@mobileye.com \
--cc=andi.shyti@kernel.org \
--cc=aniket.randive@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viken.dadhaniya@oss.qualcomm.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox