From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCFBAC433C1 for ; Tue, 30 Mar 2021 14:05:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A68CE619BA for ; Tue, 30 Mar 2021 14:05:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231952AbhC3OEk (ORCPT ); Tue, 30 Mar 2021 10:04:40 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:14640 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232109AbhC3OEX (ORCPT ); Tue, 30 Mar 2021 10:04:23 -0400 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4F8rj328nLzl3rq; Tue, 30 Mar 2021 22:01:43 +0800 (CST) Received: from [10.69.38.196] (10.69.38.196) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.498.0; Tue, 30 Mar 2021 22:04:09 +0800 Subject: Re: [PATCH v4 0/4] Add support for HiSilicon I2C controller To: Andy Shevchenko CC: , , , , , , , , , References: <1617109549-4013-1-git-send-email-yangyicong@hisilicon.com> From: Yicong Yang Message-ID: Date: Tue, 30 Mar 2021 22:04:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.69.38.196] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On 2021/3/30 21:39, Andy Shevchenko wrote: > On Tue, Mar 30, 2021 at 09:05:45PM +0800, Yicong Yang wrote: >> Add driver and MAINTAINERS for HiSilicon I2C controller on Kunpeng SoC. Also >> provide the devm_*() variants for adding the I2C adapters and a public >> api to provide I2C frequency mode strings. >> >> Change since v3: > >> - split the bus mode string api to I2C as suggested by Andy > > I have prepared patch to convert i2c designware to use it. > So, feel free to attach to your series in v5. > sure. i'll address the comments and send an updated series with your patch attached. i already have it in my mailbox. :) >> - simplify the devm variants and change the export format >> - address the comments of the HiSilicon I2C driver from Andy and Dmitry, thanks! >> Link: https://lore.kernel.org/linux-i2c/1616411413-7177-1-git-send-email-yangyicong@hisilicon.com/ >> >> Change since v2: >> - handle -EPROBE_DEFER case when get irq number by platform_get_irq() >> Link: https://lore.kernel.org/linux-i2c/1615296137-14558-1-git-send-email-yangyicong@hisilicon.com/ >> >> Change since v1: >> - fix compile test error on 32bit arch, reported by intel lkp robot: >> 64 bit division without using kernel wrapper in probe function. >> Link:https://lore.kernel.org/linux-i2c/1615016946-55670-1-git-send-email-yangyicong@hisilicon.com/ >> >> Yicong Yang (4): >> i2c: core: add managed function for adding i2c adapters >> i2c: core: add api to provide frequency mode strings >> i2c: add support for HiSilicon I2C controller >> MAINTAINERS: Add maintainer for HiSilicon I2C driver >> >> MAINTAINERS | 7 + >> drivers/i2c/busses/Kconfig | 10 + >> drivers/i2c/busses/Makefile | 1 + >> drivers/i2c/busses/i2c-hisi.c | 510 ++++++++++++++++++++++++++++++++++++++++++ >> drivers/i2c/i2c-core-base.c | 26 +++ >> include/linux/i2c.h | 21 ++ >> 6 files changed, 575 insertions(+) >> create mode 100644 drivers/i2c/busses/i2c-hisi.c >> >> -- >> 2.8.1 >> >