From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6B50360746; Tue, 27 Jan 2026 15:26:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769527576; cv=none; b=EdB9jKGrrJR6WoIldFb1wMi3of0ICpNLmo7XAOqgk7XWsWVEmRR6ZrkX1Ox1fI7DE3qM9LOKLKb0R/vSlkWSKxojARBp2y1lVdCOPUdkbc4nVxbXCOx9w19MGoD7LY3om+FvkXGuoPq8ouKrEZp7ZUmOyDgytOo9MesRJRyFrVk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769527576; c=relaxed/simple; bh=mv+xNoximdUqTk04oROrEurHmuvlFVWRCPrHErUlWow=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=A9s1DYHXU5ysdpZmcHrVG/C4cOXsgUIJxoIlE6O7VVjtvup/+HlXxb44chqXpnAwt7Tj/wDb2w6Vznh5iuhcVySKPom7FC8TvVtpe9IXqSennpU273GLqinVn8gZRGl6PKHG5rH8qi9qLCz7HP7Y1BHt9yj7U8a1d+BNn6wz1zo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=OiODPW+6; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="OiODPW+6" Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 60R728DH019338; Tue, 27 Jan 2026 15:26:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=dlmBsj kw84x+g5b6TsR7HoVLKdYHJCQQk3graKa+piU=; b=OiODPW+6UB6ood4M+i8oMF /mQ3zXfBJOFJlgNKePoM+Ywh3nTTHQw4KQjKvfe9fYO7DAcUXWD81DX5Hv7U4kE8 Ncg3sfSZ9drf+wZHnXC2G93AqFRdizN9udFk2xEQvooQan3R2r8TtLTgJXI3RNh0 rfd21JryLEJvnjk1WEP2RQHC1mNt+3yBeh7oWPKX9JrfgRDbsRxibb9pEh5UD85c G94LSW+DlvVRAvLJfNPQABb8p7qpBBBQif5Yaa/T1ZZRW/3wPSWmMdIsvRu3SdiS u3ZyRSthl8LzI2DcaW6uvBuWtFSHScPdVHQefBMTseMrwOMdY244/eotEpZbA4iQ == Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4bvmgfvgb9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Jan 2026 15:26:06 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 60RCcnkw031024; Tue, 27 Jan 2026 15:26:06 GMT Received: from smtprelay06.dal12v.mail.ibm.com ([172.16.1.8]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4bw8dsh8fh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Jan 2026 15:26:06 +0000 Received: from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com [10.241.53.104]) by smtprelay06.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 60RFQ5uq21824146 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Jan 2026 15:26:05 GMT Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A0F0C58067; Tue, 27 Jan 2026 15:26:05 +0000 (GMT) Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5825158052; Tue, 27 Jan 2026 15:26:05 +0000 (GMT) Received: from [9.61.135.234] (unknown [9.61.135.234]) by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP; Tue, 27 Jan 2026 15:26:05 +0000 (GMT) Message-ID: Date: Tue, 27 Jan 2026 09:26:05 -0600 Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 04/13] i2c: fsi: Drop assigning fsi bus To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= Cc: Ninad Palsule , linux-fsi@lists.ozlabs.org, Andi Shyti , linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <8a36a0dba809d3bfe225627fd178daece10ff6a5.1765279318.git.u.kleine-koenig@baylibre.com> Content-Language: en-US From: Eddie James In-Reply-To: <8a36a0dba809d3bfe225627fd178daece10ff6a5.1765279318.git.u.kleine-koenig@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=Z4vh3XRA c=1 sm=1 tr=0 ts=6978d90e cx=c_pps a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VnNF1IyMAAAA:8 a=IpJZQVW2AAAA:8 a=VwQbUJbxAAAA:8 a=bKyC4-_fwZ91YHrlqQQA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IawgGOuG5U0WyFbmm1f5:22 X-Proofpoint-GUID: _tXxP29DnSdE9Dv-CgRG3n93ZaHxvkB- X-Proofpoint-ORIG-GUID: _tXxP29DnSdE9Dv-CgRG3n93ZaHxvkB- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI3MDEyNSBTYWx0ZWRfX0bXzp67aL2Ds F/wG1c2vZ3hnUQrDwQxaLpRknGyXsfWeFdgd8in5ILCesRpWUqsdkCfsijBRciJmKRZvqVLy/Gx aM0dNRqjHLgjoVuHpzEqWJxq3LF0Bb5E+Q5iXzs1NjtAG4xayjG5jr88t4xJcCZFYeePmwOzJA8 SqwPeHJERph1/qzYaWHtjGXlVLf6+mYL3bXAXAYnyx/ladkbLfOMu9UfFVawKotKIMgKqM+ZRcV o4xPe+YSbvSf6nIO18djR5cBigdzgD60UjcdtSxMpZ+Pa/zHcmd8CYr+DvS6P5YH0IMIUEgC7cH y3t87tOkg74RlpbF/SQ/41nC7tBbdJoZ5eycj117JoMnQpvK9dMlW8mpBEVo3+godtunDScvU6p R8r7C07pRM/bLbXKunG7ZxKYbGSYFL607S3aTFrgTjxgS8pMYUcgLHno8c/iIYuy8HQ3eKo9FjV vzdyxohqLoBonraPEIg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-27_03,2026-01-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 phishscore=0 priorityscore=1501 bulkscore=0 adultscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2601150000 definitions=main-2601270125 On 12/9/25 5:40 AM, Uwe Kleine-König wrote: > Since commit FIXME ("fsi: Assign driver's bus in fsi_driver_register()") > module_fsi_driver() cares about assigning the driver's bus member. Drop > the explicit driver specific assignment. Acked-by: Eddie James > > Signed-off-by: Uwe Kleine-König > Reviewed-by: Andi Shyti > --- > drivers/i2c/busses/i2c-fsi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-fsi.c b/drivers/i2c/busses/i2c-fsi.c > index ae016a9431da..e98dd5dcac0f 100644 > --- a/drivers/i2c/busses/i2c-fsi.c > +++ b/drivers/i2c/busses/i2c-fsi.c > @@ -763,7 +763,6 @@ static struct fsi_driver fsi_i2c_driver = { > .id_table = fsi_i2c_ids, > .drv = { > .name = "i2c-fsi", > - .bus = &fsi_bus_type, > .probe = fsi_i2c_probe, > .remove = fsi_i2c_remove, > },