From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dmitry Osipenko <digetx@gmail.com>
Subject: Re: [PATCH V2] drivers: i2c: tegra: fix checkpatch defects
Date: Thu, 30 May 2019 14:36:39 +0300
Message-ID: <e9e3d8b0-a76a-81a9-1110-2d07ba1c787f@gmail.com>
References: <1559196850-7007-1-git-send-email-bbiswas@nvidia.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1559196850-7007-1-git-send-email-bbiswas@nvidia.com>
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
To: Bitan Biswas <bbiswas@nvidia.com>, Laxman Dewangan <ldewangan@nvidia.com>, Thierry Reding <treding@nvidia.com>, Jonathan Hunter <jonathanh@nvidia.com>, linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Shardar Mohammed <smohammed@nvidia.com>, Sowjanya Komatineni <skomatineni@nvidia.com>, Mantravadi Karthik <mkarthik@nvidia.com>
List-Id: linux-i2c@vger.kernel.org

30.05.2019 9:14, Bitan Biswas пишет:
> Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c
> except for BUG/BUG_ON checks

Please turn the BUG_ON's into WARN_ON's. The machine won't go on fire,
hence there is absolutely no good reason in making system unusable on a
software bug. BUG_ON may be more useful for development, but not for a
casual daily usage.

> Signed-off-by: Bitan Biswas <bbiswas@nvidia.com>
> ---

> @@ -1034,7 +1038,7 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev,
>  	u32 *buffer = NULL;
>  	int err = 0;
>  	bool dma;
> -	u16 xfer_time = 100;
> +	u16 xfer_tm = 100;

What's wrong with the "time"? I'm finding the "xfer_tm" as a very
unintuitive naming.

-- 
Dmitry