From: Peter Rosin <peda@axentia.se>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-i2c <linux-i2c@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] eeprom: at24: use a common prefix for all symbols in at24.c
Date: Wed, 6 Dec 2017 18:27:25 +0100 [thread overview]
Message-ID: <ea0eb0b0-89bd-77d2-c2db-8b87c266de92@axentia.se> (raw)
In-Reply-To: <CAMRc=MfjGSo0bsmoLJGU_vFyp=E8b6-JJwmS5N5vorDpWhEB-Q@mail.gmail.com>
On 2017-12-06 15:29, Bartosz Golaszewski wrote:
> 2017-12-06 14:40 GMT+01:00 Peter Rosin <peda@axentia.se>:
>> Hi!
>>
>> Some nits...
>>
>> On 2017-12-06 14:01, Bartosz Golaszewski wrote:
>>> There are a couple symbols defined in the driver source file which are
>>> missing the at24_ prefix. This patch fixes that.
>>>
>>> For module params: use module_param_named() in order not to break the
>>> userspace.
>>
>> I'd write that as "...in order to not break userspace"
>>
>
> I would love to hear an English native speaker's opinion on that. :)
"not to" or "to not" is a matter of style/taste. I mainly wanted to point
out that the definite article of "userspace" should be removed, because
you are not talking about one particular userspace.
Cheers,
peda
prev parent reply other threads:[~2017-12-06 17:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 13:01 [PATCH v2 0/2] eeprom: at24: coding style fixes Bartosz Golaszewski
2017-12-06 13:01 ` [PATCH v2 1/2] eeprom: at24: fix coding style issues Bartosz Golaszewski
2017-12-06 13:01 ` [PATCH v2 2/2] eeprom: at24: use a common prefix for all symbols in at24.c Bartosz Golaszewski
2017-12-06 13:40 ` Peter Rosin
2017-12-06 14:29 ` Bartosz Golaszewski
2017-12-06 17:27 ` Peter Rosin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea0eb0b0-89bd-77d2-c2db-8b87c266de92@axentia.se \
--to=peda@axentia.se \
--cc=brgl@bgdev.pl \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).