* [PATCH] i2c: fix ACPI_I2C_OPREGION dependency
@ 2017-11-22 17:05 Eric Auger
2018-01-02 18:07 ` Sinan Kaya
0 siblings, 1 reply; 6+ messages in thread
From: Eric Auger @ 2017-11-22 17:05 UTC (permalink / raw)
To: eric.auger.pro, eric.auger, wsa, linux-i2c, linux-kernel, okaya
If CONFIG_I2C=m we fail getting ACPI_I2C_OPREGION set. Let's
make ACPI_I2C_OPREGION depend on I2C.
Signed-off-by: Eric Auger <eric.auger@redhat.com>
---
drivers/i2c/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
index efc3354..5951e9d 100644
--- a/drivers/i2c/Kconfig
+++ b/drivers/i2c/Kconfig
@@ -26,7 +26,7 @@ config I2C
config ACPI_I2C_OPREGION
bool "ACPI I2C Operation region support"
- depends on I2C=y && ACPI
+ depends on I2C && ACPI
default y
help
Say Y here if you want to enable ACPI I2C operation region support.
--
2.5.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: fix ACPI_I2C_OPREGION dependency
2017-11-22 17:05 [PATCH] i2c: fix ACPI_I2C_OPREGION dependency Eric Auger
@ 2018-01-02 18:07 ` Sinan Kaya
2018-01-02 18:10 ` Randy Dunlap
0 siblings, 1 reply; 6+ messages in thread
From: Sinan Kaya @ 2018-01-02 18:07 UTC (permalink / raw)
To: Eric Auger, eric.auger.pro, wsa, linux-i2c, linux-kernel,
linux-acpi@vger.kernel.org
+linux-acpi
On 11/22/2017 12:05 PM, Eric Auger wrote:
> If CONFIG_I2C=m we fail getting ACPI_I2C_OPREGION set. Let's
> make ACPI_I2C_OPREGION depend on I2C.
>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> ---
> drivers/i2c/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
> index efc3354..5951e9d 100644
> --- a/drivers/i2c/Kconfig
> +++ b/drivers/i2c/Kconfig
> @@ -26,7 +26,7 @@ config I2C
>
> config ACPI_I2C_OPREGION
> bool "ACPI I2C Operation region support"
> - depends on I2C=y && ACPI
> + depends on I2C && ACPI
> default y
> help
> Say Y here if you want to enable ACPI I2C operation region support.
>
Anybody picking this up?
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: fix ACPI_I2C_OPREGION dependency
2018-01-02 18:07 ` Sinan Kaya
@ 2018-01-02 18:10 ` Randy Dunlap
2018-01-02 18:19 ` Sinan Kaya
0 siblings, 1 reply; 6+ messages in thread
From: Randy Dunlap @ 2018-01-02 18:10 UTC (permalink / raw)
To: Sinan Kaya, Eric Auger, eric.auger.pro, wsa, linux-i2c,
linux-kernel, linux-acpi@vger.kernel.org
On 01/02/2018 10:07 AM, Sinan Kaya wrote:
> +linux-acpi
>
> On 11/22/2017 12:05 PM, Eric Auger wrote:
>> If CONFIG_I2C=m we fail getting ACPI_I2C_OPREGION set. Let's
>> make ACPI_I2C_OPREGION depend on I2C.
>>
>> Signed-off-by: Eric Auger <eric.auger@redhat.com>
>> ---
>> drivers/i2c/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
>> index efc3354..5951e9d 100644
>> --- a/drivers/i2c/Kconfig
>> +++ b/drivers/i2c/Kconfig
>> @@ -26,7 +26,7 @@ config I2C
>>
>> config ACPI_I2C_OPREGION
>> bool "ACPI I2C Operation region support"
>> - depends on I2C=y && ACPI
>> + depends on I2C && ACPI
>> default y
>> help
>> Say Y here if you want to enable ACPI I2C operation region support.
>>
>
> Anybody picking this up?
Well. It looks to me like the patch is reversed or the patch description
needs some improvement. Or I just don't understand it.
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: fix ACPI_I2C_OPREGION dependency
2018-01-02 18:10 ` Randy Dunlap
@ 2018-01-02 18:19 ` Sinan Kaya
2018-01-03 13:39 ` Sinan Kaya
0 siblings, 1 reply; 6+ messages in thread
From: Sinan Kaya @ 2018-01-02 18:19 UTC (permalink / raw)
To: Randy Dunlap, Eric Auger, eric.auger.pro, wsa, linux-i2c,
linux-kernel, linux-acpi@vger.kernel.org
On 1/2/2018 1:10 PM, Randy Dunlap wrote:
>>> config ACPI_I2C_OPREGION
>>> bool "ACPI I2C Operation region support"
>>> - depends on I2C=y && ACPI
>>> + depends on I2C && ACPI
>>> default y
>>> help
>>> Say Y here if you want to enable ACPI I2C operation region support.
>>>
>> Anybody picking this up?
> Well. It looks to me like the patch is reversed or the patch description
> needs some improvement. Or I just don't understand it.
I'll let Eric improve the description.
Issue is that if you compile I2C as a module, ACPI_I2C_OPREGION doesn't get selected.
Therefore, any ACPI opregion calls targeting I2C fail with no opregion found.
The goal is to select ACPI_I2C_OPREGION independent of the I2C module type selection.
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: fix ACPI_I2C_OPREGION dependency
2018-01-02 18:19 ` Sinan Kaya
@ 2018-01-03 13:39 ` Sinan Kaya
2018-01-03 14:03 ` Auger Eric
0 siblings, 1 reply; 6+ messages in thread
From: Sinan Kaya @ 2018-01-03 13:39 UTC (permalink / raw)
To: Randy Dunlap, Eric Auger, eric.auger.pro, wsa, linux-i2c,
linux-kernel, linux-acpi@vger.kernel.org
On 1/2/2018 1:19 PM, Sinan Kaya wrote:
> On 1/2/2018 1:10 PM, Randy Dunlap wrote:
>>>> config ACPI_I2C_OPREGION
>>>> bool "ACPI I2C Operation region support"
>>>> - depends on I2C=y && ACPI
>>>> + depends on I2C && ACPI
>>>> default y
>>>> help
>>>> Say Y here if you want to enable ACPI I2C operation region support.
>>>>
>>> Anybody picking this up?
>> Well. It looks to me like the patch is reversed or the patch description
>> needs some improvement. Or I just don't understand it.
>
> I'll let Eric improve the description.
>
> Issue is that if you compile I2C as a module, ACPI_I2C_OPREGION doesn't get selected.
> Therefore, any ACPI opregion calls targeting I2C fail with no opregion found.
>
> The goal is to select ACPI_I2C_OPREGION independent of the I2C module type selection.
>
I hope I was able to explain it. =y above is the problem. This config option will only
be selected if module is built-in not for m case.
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: fix ACPI_I2C_OPREGION dependency
2018-01-03 13:39 ` Sinan Kaya
@ 2018-01-03 14:03 ` Auger Eric
0 siblings, 0 replies; 6+ messages in thread
From: Auger Eric @ 2018-01-03 14:03 UTC (permalink / raw)
To: Sinan Kaya, Randy Dunlap, eric.auger.pro, wsa, linux-i2c,
linux-kernel, linux-acpi@vger.kernel.org
Hi Sinan,
On 03/01/18 14:39, Sinan Kaya wrote:
> On 1/2/2018 1:19 PM, Sinan Kaya wrote:
>> On 1/2/2018 1:10 PM, Randy Dunlap wrote:
>>>>> config ACPI_I2C_OPREGION
>>>>> bool "ACPI I2C Operation region support"
>>>>> - depends on I2C=y && ACPI
>>>>> + depends on I2C && ACPI
>>>>> default y
>>>>> help
>>>>> Say Y here if you want to enable ACPI I2C operation region support.
>>>>>
>>>> Anybody picking this up?
>>> Well. It looks to me like the patch is reversed or the patch description
>>> needs some improvement. Or I just don't understand it.
>>
>> I'll let Eric improve the description.
>>
>> Issue is that if you compile I2C as a module, ACPI_I2C_OPREGION doesn't get selected.
>> Therefore, any ACPI opregion calls targeting I2C fail with no opregion found.
>>
>> The goal is to select ACPI_I2C_OPREGION independent of the I2C module type selection.
>>
>
> I hope I was able to explain it. =y above is the problem. This config option will only
> be selected if module is built-in not for m case.
Thank you for your input. I just sent a v2 with reworded commit message.
Hope this makes more sense.
Thanks
Eric
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-01-03 14:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-22 17:05 [PATCH] i2c: fix ACPI_I2C_OPREGION dependency Eric Auger
2018-01-02 18:07 ` Sinan Kaya
2018-01-02 18:10 ` Randy Dunlap
2018-01-02 18:19 ` Sinan Kaya
2018-01-03 13:39 ` Sinan Kaya
2018-01-03 14:03 ` Auger Eric
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).