From: Dmitry Osipenko <digetx@gmail.com>
To: Bitan Biswas <bbiswas@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Thierry Reding <treding@nvidia.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Shardar Mohammed <smohammed@nvidia.com>,
Sowjanya Komatineni <skomatineni@nvidia.com>,
Mantravadi Karthik <mkarthik@nvidia.com>
Subject: Re: [PATCH V4] drivers: i2c: tegra: fix checkpatch defects
Date: Thu, 6 Jun 2019 18:34:24 +0300 [thread overview]
Message-ID: <eafab1bf-82bb-ecbb-e3b3-332c3db620c2@gmail.com> (raw)
In-Reply-To: <e8c2f722-eeaa-7449-d4fb-6caf0466bcc8@nvidia.com>
06.06.2019 17:02, Bitan Biswas пишет:
>
>
> On 6/6/19 4:39 AM, Dmitry Osipenko wrote:
>> 06.06.2019 10:35, Bitan Biswas пишет:
>>> Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c
>>>
>>> Remove redundant BUG_ON calls or replace with WARN_ON_ONCE
>>> as needed. Replace BUG() with error handling code.
>>> Define I2C_ERR_UNEXPECTED_STATUS for error handling.
>>>
>>> Signed-off-by: Bitan Biswas <bbiswas@nvidia.com>
>>> ---
>>> drivers/i2c/busses/i2c-tegra.c | 67
>>> +++++++++++++++++++++++-------------------
>>> 1 file changed, 37 insertions(+), 30 deletions(-)
>>>
>>> diff --git a/drivers/i2c/busses/i2c-tegra.c
>>> b/drivers/i2c/busses/i2c-tegra.c
>>> index 76b7926..55a5d87 100644
>>> --- a/drivers/i2c/busses/i2c-tegra.c
>>> +++ b/drivers/i2c/busses/i2c-tegra.c
>>> @@ -78,6 +78,7 @@
>>> #define I2C_ERR_NO_ACK 0x01
>>> #define I2C_ERR_ARBITRATION_LOST 0x02
>>> #define I2C_ERR_UNKNOWN_INTERRUPT 0x04
>>> +#define I2C_ERR_UNEXPECTED_STATUS 0x08
>>> #define PACKET_HEADER0_HEADER_SIZE_SHIFT 28
>>> #define PACKET_HEADER0_PACKET_ID_SHIFT 16
>>> @@ -112,7 +113,7 @@
>>> #define I2C_CLKEN_OVERRIDE 0x090
>>> #define I2C_MST_CORE_CLKEN_OVR BIT(0)
>>> -#define I2C_CONFIG_LOAD_TIMEOUT 1000000
>>> +#define I2C_CONFIG_LOAD_TMOUT 1000000
>>> #define I2C_MST_FIFO_CONTROL 0x0b4
>>> #define I2C_MST_FIFO_CONTROL_RX_FLUSH BIT(0)
>>> @@ -280,6 +281,7 @@ struct tegra_i2c_dev {
>>> u32 bus_clk_rate;
>>> u16 clk_divisor_non_hs_mode;
>>> bool is_multimaster_mode;
>>> + /* xfer_lock: lock to serialize transfer submission and
>>> processing */
>>> spinlock_t xfer_lock;
>>> struct dma_chan *tx_dma_chan;
>>> struct dma_chan *rx_dma_chan;
>>> @@ -306,7 +308,7 @@ static u32 dvc_readl(struct tegra_i2c_dev
>>> *i2c_dev, unsigned long reg)
>>> * to the I2C block inside the DVC block
>>> */
>>> static unsigned long tegra_i2c_reg_addr(struct tegra_i2c_dev *i2c_dev,
>>> - unsigned long reg)
>>> + unsigned long reg)
>>> {
>>> if (i2c_dev->is_dvc)
>>> reg += (reg >= I2C_TX_FIFO) ? 0x10 : 0x40;
>>> @@ -314,7 +316,7 @@ static unsigned long tegra_i2c_reg_addr(struct
>>> tegra_i2c_dev *i2c_dev,
>>> }
>>> static void i2c_writel(struct tegra_i2c_dev *i2c_dev, u32 val,
>>> - unsigned long reg)
>>> + unsigned long reg)
>>> {
>>> writel(val, i2c_dev->base + tegra_i2c_reg_addr(i2c_dev, reg));
>>> @@ -329,13 +331,13 @@ static u32 i2c_readl(struct tegra_i2c_dev
>>> *i2c_dev, unsigned long reg)
>>> }
>>> static void i2c_writesl(struct tegra_i2c_dev *i2c_dev, void *data,
>>> - unsigned long reg, int len)
>>> + unsigned long reg, int len)
>>> {
>>> writesl(i2c_dev->base + tegra_i2c_reg_addr(i2c_dev, reg), data,
>>> len);
>>> }
>>> static void i2c_readsl(struct tegra_i2c_dev *i2c_dev, void *data,
>>> - unsigned long reg, int len)
>>> + unsigned long reg, int len)
>>> {
>>> readsl(i2c_dev->base + tegra_i2c_reg_addr(i2c_dev, reg), data,
>>> len);
>>> }
>>> @@ -486,7 +488,7 @@ static int tegra_i2c_flush_fifos(struct
>>> tegra_i2c_dev *i2c_dev)
>>> dev_warn(i2c_dev->dev, "timeout waiting for fifo
>>> flush\n");
>>> return -ETIMEDOUT;
>>> }
>>> - msleep(1);
>>> + usleep_range(1000, 2000);
>>> }
>>> return 0;
>>> }
>>> @@ -525,7 +527,6 @@ static int tegra_i2c_empty_rx_fifo(struct
>>> tegra_i2c_dev *i2c_dev)
>>> * prevent overwriting past the end of buf
>>> */
>>> if (rx_fifo_avail > 0 && buf_remaining > 0) {
>>> - BUG_ON(buf_remaining > 3);
>>> val = i2c_readl(i2c_dev, I2C_RX_FIFO);
>>> val = cpu_to_le32(val);
>>> memcpy(buf, &val, buf_remaining);
>>> @@ -533,7 +534,6 @@ static int tegra_i2c_empty_rx_fifo(struct
>>> tegra_i2c_dev *i2c_dev)
>>> rx_fifo_avail--;
>>> }
>>> - BUG_ON(rx_fifo_avail > 0 && buf_remaining > 0);
>>> i2c_dev->msg_buf_remaining = buf_remaining;
>>> i2c_dev->msg_buf = buf;
>>> @@ -591,7 +591,6 @@ static int tegra_i2c_fill_tx_fifo(struct
>>> tegra_i2c_dev *i2c_dev)
>>> * boundary and fault.
>>> */
>>> if (tx_fifo_avail > 0 && buf_remaining > 0) {
>>> - BUG_ON(buf_remaining > 3);
>>> memcpy(&val, buf, buf_remaining);
>>> val = le32_to_cpu(val);
>>> @@ -680,10 +679,11 @@ static int
>>> tegra_i2c_wait_for_config_load(struct tegra_i2c_dev *i2c_dev)
>>> i2c_writel(i2c_dev, I2C_MSTR_CONFIG_LOAD, I2C_CONFIG_LOAD);
>>> if (in_interrupt())
>>> err = readl_poll_timeout_atomic(addr, val, val == 0,
>>> - 1000, I2C_CONFIG_LOAD_TIMEOUT);
>>> + 1000,
>>> + I2C_CONFIG_LOAD_TMOUT);
>>> else
>>> - err = readl_poll_timeout(addr, val, val == 0,
>>> - 1000, I2C_CONFIG_LOAD_TIMEOUT);
>>> + err = readl_poll_timeout(addr, val, val == 0, 1000,
>>> + I2C_CONFIG_LOAD_TMOUT);
>>> if (err) {
>>> dev_warn(i2c_dev->dev,
>>> @@ -858,16 +858,21 @@ static irqreturn_t tegra_i2c_isr(int irq, void
>>> *dev_id)
>>> if (i2c_dev->msg_read && (status &
>>> I2C_INT_RX_FIFO_DATA_REQ)) {
>>> if (i2c_dev->msg_buf_remaining)
>>> tegra_i2c_empty_rx_fifo(i2c_dev);
>>> - else
>>> - BUG();
>>> + else {
>>> + dev_err(i2c_dev->dev, "unexpected rx data request\n");
>>> + i2c_dev->msg_err |= I2C_ERR_UNEXPECTED_STATUS;
>>> + goto err;
>>> + }
>>> }
>>> if (!i2c_dev->msg_read && (status &
>>> I2C_INT_TX_FIFO_DATA_REQ)) {
>>> - if (i2c_dev->msg_buf_remaining)
>>> - tegra_i2c_fill_tx_fifo(i2c_dev);
>>> - else
>>> + if (i2c_dev->msg_buf_remaining) {
>>> + if (tegra_i2c_fill_tx_fifo(i2c_dev))
>>> + goto err;
>>> + } else {
>>> tegra_i2c_mask_irq(i2c_dev,
>>> I2C_INT_TX_FIFO_DATA_REQ);
>>> + }
>>> }
>>> }
>>> @@ -885,7 +890,7 @@ static irqreturn_t tegra_i2c_isr(int irq, void
>>> *dev_id)
>>> if (status & I2C_INT_PACKET_XFER_COMPLETE) {
>>> if (i2c_dev->is_curr_dma_xfer)
>>> i2c_dev->msg_buf_remaining = 0;
>>> - BUG_ON(i2c_dev->msg_buf_remaining);
>>> + WARN_ON_ONCE(i2c_dev->msg_buf_remaining);
>>> complete(&i2c_dev->msg_complete);
>>> }
>>> goto done;
>>> @@ -1024,7 +1029,7 @@ static int tegra_i2c_issue_bus_clear(struct
>>> i2c_adapter *adap)
>>> }
>>> static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev,
>>> - struct i2c_msg *msg, enum msg_end_type end_state)
>>> + struct i2c_msg *msg, enum msg_end_type end_state)
>>> {
>>> u32 packet_header;
>>> u32 int_mask;
>>> @@ -1034,7 +1039,7 @@ static int tegra_i2c_xfer_msg(struct
>>> tegra_i2c_dev *i2c_dev,
>>> u32 *buffer = NULL;
>>> int err = 0;
>>> bool dma;
>>> - u16 xfer_time = 100;
>>> + u16 xfer_tm = 100;
>>
>> Why xfer_time is renamed? It is much more important to keep code
>> readable rather than to satisfy checkpatch. You should *not* follow
>> checkpatch recommendations where they do not make much sense. The
>> xfer_tm is a less intuitive naming and hence it harms readability of the
>> code. Hence it is better to have "lines over 80 chars" in this
>> particular case.
> Agreed. I shall share updated patch.
Yes, please.
>>
>> Also, please don't skip review comments. I already pointed out the above
>> in the answer to previous version of the patch.
>>
> I apologize for the oversight. I shall be more careful in future.
No problems ;)
next prev parent reply other threads:[~2019-06-06 15:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 7:35 [PATCH V4] drivers: i2c: tegra: fix checkpatch defects Bitan Biswas
2019-06-06 11:39 ` Dmitry Osipenko
2019-06-06 14:02 ` Bitan Biswas
2019-06-06 15:34 ` Dmitry Osipenko [this message]
2019-06-06 11:57 ` Wolfram Sang
2019-06-06 18:22 ` Bitan Biswas
2019-06-06 20:45 ` Peter Rosin
2019-06-07 3:40 ` Bitan Biswas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eafab1bf-82bb-ecbb-e3b3-332c3db620c2@gmail.com \
--to=digetx@gmail.com \
--cc=bbiswas@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkarthik@nvidia.com \
--cc=skomatineni@nvidia.com \
--cc=smohammed@nvidia.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox