[PATCH] i2c: Remove 'default n' from busses/Kconfig

[PATCH] i2c: Remove 'default n' from busses/Kconfig

[Jarkko Nikula]

The default value for a config option defaults to 'n' so it doesn't need
to be set here.

Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
---
 drivers/i2c/busses/Kconfig | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 085ca9b009ed..9731121ec561 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -840,7 +840,6 @@ config I2C_PASEMI
 config I2C_PCA_PLATFORM
 	tristate "PCA9564/PCA9665 as platform device"
 	select I2C_ALGOPCA
-	default n
 	help
 	  This driver supports a memory mapped Philips PCA9564/PCA9665
 	  parallel bus to I2C bus controller.
@@ -1251,7 +1250,6 @@ config I2C_TAOS_EVM
 	depends on TTY
 	select SERIO
 	select SERIO_SERPORT
-	default n
 	help
 	  This supports TAOS evaluation modules on serial port. In order to
 	  use this driver, you will need the inputattach tool, which is part
@@ -1335,7 +1333,6 @@ config I2C_PCA_ISA
 	tristate "PCA9564/PCA9665 on an ISA bus"
 	depends on ISA
 	select I2C_ALGOPCA
-	default n
 	help
 	  This driver supports ISA boards using the Philips PCA9564/PCA9665
 	  parallel bus to I2C bus controller.
-- 
2.28.0

Re: [PATCH] i2c: Remove 'default n' from busses/Kconfig

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

On Thu, Aug 20, 2020 at 11:05:25AM +0300, Jarkko Nikula wrote:
> The default value for a config option defaults to 'n' so it doesn't need
> to be set here.
> 
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>

Applied to for-next, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] i2c: Remove 'default n' from busses/Kconfig

[Jean Delvare]

On Thu, 20 Aug 2020 11:05:25 +0300, Jarkko Nikula wrote:
> The default value for a config option defaults to 'n' so it doesn't need
> to be set here.
> 
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> ---
>  drivers/i2c/busses/Kconfig | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 085ca9b009ed..9731121ec561 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -840,7 +840,6 @@ config I2C_PASEMI
>  config I2C_PCA_PLATFORM
>  	tristate "PCA9564/PCA9665 as platform device"
>  	select I2C_ALGOPCA
> -	default n
>  	help
>  	  This driver supports a memory mapped Philips PCA9564/PCA9665
>  	  parallel bus to I2C bus controller.
> @@ -1251,7 +1250,6 @@ config I2C_TAOS_EVM
>  	depends on TTY
>  	select SERIO
>  	select SERIO_SERPORT
> -	default n
>  	help
>  	  This supports TAOS evaluation modules on serial port. In order to
>  	  use this driver, you will need the inputattach tool, which is part
> @@ -1335,7 +1333,6 @@ config I2C_PCA_ISA
>  	tristate "PCA9564/PCA9665 on an ISA bus"
>  	depends on ISA
>  	select I2C_ALGOPCA
> -	default n
>  	help
>  	  This driver supports ISA boards using the Philips PCA9564/PCA9665
>  	  parallel bus to I2C bus controller.

Definitely a good move, this was on my informal to-do list for some
time already...

Option I2C_STUB suffers from the same but uses a different syntax,
which may explain why you missed it.

Reviewed-by: Jean Delvare <jdelvare@suse.de>

-- 
Jean Delvare
SUSE L3 Support

Re: [PATCH] i2c: Remove 'default n' from busses/Kconfig

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]


> Option I2C_STUB suffers from the same but uses a different syntax,
> which may explain why you missed it.
> 
> Reviewed-by: Jean Delvare <jdelvare@suse.de>

I removed that one, too, and added your tag. Thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] i2c: Remove 'default n' from busses/Kconfig

[Jarkko Nikula]

On 8/25/20 10:51 AM, Wolfram Sang wrote:
> 
>> Option I2C_STUB suffers from the same but uses a different syntax,
>> which may explain why you missed it.
>>
>> Reviewed-by: Jean Delvare <jdelvare@suse.de>
> 
> I removed that one, too, and added your tag. Thanks!
> 
Ah, thanks! I was just going to send another patch removing it :-)

Jarkko