From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>, Andi Shyti <andi.shyti@kernel.org>,
linux-i2c@vger.kernel.org,
Sanket Goswami <Sanket.Goswami@amd.com>
Subject: Re: [PATCH 1/2] i2c: amd: Switch to guard(mutex)
Date: Mon, 24 Feb 2025 11:53:19 +0200 [thread overview]
Message-ID: <eba0150e-dcb7-4686-a768-83ed6ef1437f@linux.intel.com> (raw)
In-Reply-To: <Z7OZvxCCnil-nerR@smile.fi.intel.com>
On 2/17/25 10:19 PM, Andy Shevchenko wrote:
> On Mon, Feb 17, 2025 at 06:17:08PM +0530, Shyam Sundar S K wrote:
>> Instead of using the 'goto label; mutex_unlock()' pattern use
>> 'guard(mutex)' which will release the mutex when it goes out of scope.
>
> Both LGTM,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> But next time either sent them separately (seems like they are independent),
> or add a cover letter explaining what the big picture behind all the patches
> as a whole.
>
To both:
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
prev parent reply other threads:[~2025-02-24 9:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 12:47 [PATCH 1/2] i2c: amd: Switch to guard(mutex) Shyam Sundar S K
2025-02-17 12:47 ` [PATCH 2/2] i2c: dw: Update the master_xfer callback name Shyam Sundar S K
2025-02-17 20:19 ` [PATCH 1/2] i2c: amd: Switch to guard(mutex) Andy Shevchenko
2025-02-18 7:09 ` Shyam Sundar S K
2025-02-24 9:53 ` Jarkko Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eba0150e-dcb7-4686-a768-83ed6ef1437f@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=Sanket.Goswami@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox