From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc@vger.kernel.org,
Andi Shyti <andi.shyti@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] i2c: rcar: reset controller is mandatory for Gen3+
Date: Fri, 22 Sep 2023 09:05:55 +0200 (CEST) [thread overview]
Message-ID: <eca9a551-1b46-ad3c-97c-fd48852ebace@linux-m68k.org> (raw)
In-Reply-To: <20230921125351.3954-2-wsa+renesas@sang-engineering.com>
On Thu, 21 Sep 2023, Wolfram Sang wrote:
> Initially, we only needed a reset controller to make sure RXDMA works at
> least once per transfer. Meanwhile, documentation has been updated. It
> now says that a reset has to be performed prior every transaction, even
> if it is non-DMA. So, make the reset controller a requirement instead of
> being optional. And bail out if resetting fails.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Change since v2:
> * properly bail out on errors using goto
> To make that easier, the reset controller is now probed after the
> handling of pm_runtime_put() is determined
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2023-09-22 7:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 12:53 [PATCH v3 0/2] i2c: rcar: improve Gen3 support Wolfram Sang
2023-09-21 12:53 ` [PATCH v3 1/2] i2c: rcar: reset controller is mandatory for Gen3+ Wolfram Sang
2023-09-21 21:22 ` Andi Shyti
2023-09-22 7:05 ` Geert Uytterhoeven [this message]
2023-09-22 9:55 ` Wolfram Sang
2023-09-21 12:53 ` [PATCH v3 2/2] i2c: rcar: improve accuracy for R-Car Gen3+ Wolfram Sang
2023-09-21 21:27 ` Andi Shyti
2023-09-22 7:02 ` Geert Uytterhoeven
2023-09-22 9:55 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eca9a551-1b46-ad3c-97c-fd48852ebace@linux-m68k.org \
--to=geert@linux-m68k.org \
--cc=andi.shyti@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox