From: Heiner Kallweit <hkallweit1@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>,
Wolfram Sang <wsa@the-dreams.de>, Peter Rosin <peda@axentia.se>
Cc: "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH v5 0/3] i2c: introduce devm_i2c_new_dummy and use it in at24 driver
Date: Sat, 16 Dec 2017 00:00:15 +0100 [thread overview]
Message-ID: <ee904c64-e1b3-7fa0-7df4-7e77530a974a@gmail.com> (raw)
i2c_new_dummy is typically called from the probe function of the
driver for the primary i2c client. It requires calls to
i2c_unregister_device in the error path of the probe function and
in the remove function.
This can be simplified by introducing a device-managed version.
Make at24 driver the first user of the new function.
Changes in v2:
- add change to i2c core to make a version of i2c_new_device
available which returns an ERR_PTR instead of NULL in error case
- few minor improvements
Changes in v3:
- rename _i2c_new_device to __i2c_new_device
Changes in v4:
- add missing kernel doc comments
- add Reviewed-by
Changes in v5:
- fix a copy & paste error in patch 1
- improve readability in patch 2
Heiner Kallweit (3):
i2c: core: improve return value handling of i2c_new_device and i2c_new_dummy
i2c: core: add device-managed version of i2c_new_dummy
eeprom: at24: switch to device-managed version of i2c_new_dummy
Documentation/driver-model/devres.txt | 3 +
drivers/i2c/i2c-core-base.c | 115 ++++++++++++++++++++++++++++++----
drivers/misc/eeprom/at24.c | 31 ++++-----
include/linux/i2c.h | 3 +
4 files changed, 119 insertions(+), 33 deletions(-)
--
2.15.1
next reply other threads:[~2017-12-15 23:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 23:00 Heiner Kallweit [this message]
2017-12-15 23:05 ` [PATCH v5 1/3] i2c: core: improve return value handling of i2c_new_device and i2c_new_dummy Heiner Kallweit
2017-12-15 23:05 ` [PATCH v5 2/3] i2c: core: add device-managed version of i2c_new_dummy Heiner Kallweit
2017-12-18 17:50 ` Bartosz Golaszewski
2017-12-18 20:30 ` Wolfram Sang
2017-12-19 8:22 ` Bartosz Golaszewski
2017-12-19 8:28 ` Wolfram Sang
2017-12-19 8:34 ` Bartosz Golaszewski
2017-12-15 23:07 ` [PATCH v5 3/3] eeprom: at24: switch to " Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee904c64-e1b3-7fa0-7df4-7e77530a974a@gmail.com \
--to=hkallweit1@gmail.com \
--cc=brgl@bgdev.pl \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox