Re: [PATCH v2 2/6] platform/x86: dell-smo8800: Move instantiation of lis3lv02d i2c_client from i2c-i801 to dell-smo8800

kernel test robot
2024-01-13T04:42:28Z

Hi Hans,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.7]
[cannot apply to wsa/i2c/for-next next-20240112]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Hans-de-Goede/platform-x86-dell-smo8800-Change-probe-ordering-a-bit/20240107-001715
base: linus/master
patch link: https://lore.kernel.org/r/20240106160935.45487-3-hdegoede%40redhat.com
patch subject: [PATCH v2 2/6] platform/x86: dell-smo8800: Move instantiation of lis3lv02d i2c_client from i2c-i801 to dell-smo8800
config: x86_64-buildonly-randconfig-001-20240113 (https://download.01.org/0day-ci/archive/20240113/202401131227.HL4y41DY-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240113/202401131227.HL4y41DY-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401131227.HL4y41DY-lkp@intel.com/

All warnings (new ones prefixed by >>):

In function 'smo8800_instantiate_i2c_client',
inlined from 'smo8800_probe' at drivers/platform/x86/dell/dell-smo8800.c:240:2:
>> drivers/platform/x86/dell/dell-smo8800.c:188:21: warning: argument 1 null where non-null expected [-Wnonnull]
188 | if (strcmp(dmi_product_name,
| ^~~~~~~~~~~~~~~~~~~~~~~~
189 | dell_lis3lv02d_devices[i].dmi_product_name) == 0) {
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from include/linux/bitmap.h:12,
from include/linux/cpumask.h:12,
from include/linux/smp.h:13,
from include/linux/lockdep.h:14,
from include/linux/mutex.h:17,
from include/linux/kernfs.h:11,
from include/linux/sysfs.h:16,
from include/linux/kobject.h:20,
from include/linux/device/bus.h:17,
from drivers/platform/x86/dell/dell-smo8800.c:14:
include/linux/string.h: In function 'smo8800_probe':
include/linux/string.h:89:12: note: in a call to function 'strcmp' declared 'nonnull'
89 | extern int strcmp(const char *,const char *);
| ^~~~~~

vim +188 drivers/platform/x86/dell/dell-smo8800.c

173
174 static void smo8800_instantiate_i2c_client(struct smo8800_device *smo8800)
175 {
176 struct i2c_board_info info = { };
177 struct i2c_adapter *adap = NULL;
178 const char *dmi_product_name;
179 u8 addr = 0;
180 int i;
181
182 bus_for_each_dev(&i2c_bus_type, NULL, &adap, smo8800_find_i801);
183 if (!adap)
184 return;
185
186 dmi_product_name = dmi_get_system_info(DMI_PRODUCT_NAME);
187 for (i = 0; i < ARRAY_SIZE(dell_lis3lv02d_devices); ++i) {
> 188 if (strcmp(dmi_product_name,
189 dell_lis3lv02d_devices[i].dmi_product_name) == 0) {
190 addr = dell_lis3lv02d_devices[i].i2c_addr;
191 break;
192 }
193 }
194
195 if (!addr) {
196 dev_warn(smo8800->dev,
197 "Accelerometer lis3lv02d is present on SMBus but its address is unknown, skipping registration\n");
198 goto put_adapter;
199 }
200
201 info.addr = addr;
202 strscpy(info.type, "lis3lv02d", I2C_NAME_SIZE);
203
204 smo8800->i2c_dev = i2c_new_client_device(adap, &info);
205 if (IS_ERR(smo8800->i2c_dev)) {
206 dev_err_probe(smo8800->dev, PTR_ERR(smo8800->i2c_dev),
207 "registering accel i2c_client\n");
208 smo8800->i2c_dev = NULL;
209 } else {
210 dev_info(smo8800->dev, "Registered %s accelerometer on address 0x%02x\n",
211 info.type, info.addr);
212 }
213 put_adapter:
214 i2c_put_adapter(adap);
215 }
216

--
0-DAY CI Kernel Test Service