From: "Hawa, Hanna" <hhhawa@amazon.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: <jarkko.nikula@linux.intel.com>,
<mika.westerberg@linux.intel.com>, <jsd@semihalf.com>,
<linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<dwmw@amazon.co.uk>, <benh@amazon.com>, <ronenk@amazon.com>,
<talel@amazon.com>, <jonnyc@amazon.com>, <hanochu@amazon.com>,
<farbere@amazon.com>, <itamark@amazon.com>
Subject: Re: [PATCH v2 1/1] i2c: designware: set pinctrl recovery information from device pinctrl
Date: Thu, 15 Dec 2022 10:15:35 +0200 [thread overview]
Message-ID: <efa9171f-98ac-f518-e59e-f6c4d7d3d4e6@amazon.com> (raw)
In-Reply-To: <Y5n1U1lYbcbJ5U1k@smile.fi.intel.com>
On 12/14/2022 6:09 PM, Andy Shevchenko wrote:
> ...should be located here.
>
> ...
Ack - will move them.
>
>> + if (dev->dev->pins && dev->dev->pins->p)
>> + rinfo->pinctrl = dev->dev->pins->p;
> Hmm... I don't see how this field is being used.
> Can you elaborate?
This field is used in i2c_generic_scl_recovery(), if it's not NULL then
the flow will set the state to GPIO before running the recovery mechanism.
if (bri->pinctrl)
pinctrl_select_state(bri->pinctrl, bri->pins_gpio);
.
.
I saw that that the change failed in complication for SPARC
architecture, as the pins field is wraparound with CONFIG_PINCTRL in
device struct. I though on two options to solve the compilation error,
first by adding wraparound of CONFIG_PINCTRL when accessing the pins
field. And the second option is to add get function in pinctrl/devinfo.h
file, which return the pins field, or NULL in case the PINCTRL is not
defined. Which option you think we can go with?
next prev parent reply other threads:[~2022-12-15 8:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 14:27 [PATCH v2 1/1] i2c: designware: set pinctrl recovery information from device pinctrl Hanna Hawa
2022-12-14 16:09 ` Andy Shevchenko
2022-12-15 8:15 ` Hawa, Hanna [this message]
2022-12-15 10:27 ` Andy Shevchenko
2022-12-15 14:06 ` Linus Walleij
2022-12-15 14:25 ` Hawa, Hanna
2022-12-15 15:22 ` Andy Shevchenko
2022-12-16 13:50 ` Hawa, Hanna
2022-12-16 14:46 ` Andy Shevchenko
2022-12-19 19:35 ` Hawa, Hanna
2022-12-20 10:54 ` Andy Shevchenko
2022-12-14 19:14 ` kernel test robot
2022-12-15 0:17 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efa9171f-98ac-f518-e59e-f6c4d7d3d4e6@amazon.com \
--to=hhhawa@amazon.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=benh@amazon.com \
--cc=dwmw@amazon.co.uk \
--cc=farbere@amazon.com \
--cc=hanochu@amazon.com \
--cc=itamark@amazon.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jonnyc@amazon.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=ronenk@amazon.com \
--cc=talel@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox