From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77E951BD9F7 for ; Thu, 31 Oct 2024 11:13:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730373211; cv=none; b=hOjY48GEod+nwcyDalUhfm2vH/1WkYeWKPiY1QWmxsq1zf0w310R9kBfoAsyG5rxl6s0r2++6dJdjNJgkvuKQRlUVHde+FNqj4Ik9wcqfV199k02KHqcORofxQUozpaE/T6E1fFFp1AzrlxiGojuZIkSk1G+KQkGsDCA5xhGNtg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730373211; c=relaxed/simple; bh=UR+AZkACxbATXx2sqIfcnbBjwtoC++48d+OLHhNINNA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ncYUTRJGacOSnwQ9xEfEVDsg0kP/3DV8kh00yHMCSZBLUy+JyiCIWg/RqjPgTGvCZfc0b0M+IgpIfGVEQ03s0qHreB0DWup5xF6Wv85gSdWZfer+piHebivrNGVq9jKShVJ45WDLBzmN+fJTZOXg31kDzVLVCkF2+705pZU6Gmg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Bp4jGK0o; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Bp4jGK0o" Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-539e4488012so107970e87.1 for ; Thu, 31 Oct 2024 04:13:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1730373208; x=1730978008; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Qz71vnw5/+cff0GcfCxZkyXlF45Rde5KArOUta65nkg=; b=Bp4jGK0o7hpPwx/1bZUYwawQetPkA2Wvce3xZ7KQYt7kbltgWTZTFEbxtEeGjQt8M+ p9ExZ3y1vg1tIwghJudEyH4PlQw3fDoWEw3/f7XkUTCaMfAcEdi9+dWYHjmo8KIaFmLS lxk7Pn/KaLoumkaQr2o7EhM48aPXV2gtFH9gYT9l25L67CvOXhUbi39Rq2SP1thA3RA6 csbfv4AEWEGEteOj5K6znzEorNOOWn9aozGTng9njKeJlxbBDm1EUm6di5T5iIb9Ap5B ucdh4BntFTqjj8SggV2ENOdCJTnSaLVGMSEZkfEqxJk6/SEW8IpMnz87FIllJnXfAd9s VsvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730373208; x=1730978008; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Qz71vnw5/+cff0GcfCxZkyXlF45Rde5KArOUta65nkg=; b=u71Qj+xv8/ylDkQMpsAYMAK6y6tDZGg1yFKArUeSNCRb6k9+79WS4WqeZ4I2RR4kb1 8QOdnPx5JlXNpR91mO3aty42Z0VLbDXv6y8MK70D9Abe5tK08J1nFLIlw+HH/T0K65Zo R29WX4civmcxsW1ZvqesKhU9NqRxpabHOY9RXoDvlaxoYAStizUhiBTsFg2Zzu8/YUZq nyzQnSUqQ9/8R/wp/2S8cAo/ubvgTYW8waSP7m7f0OJShu7tT5t/kJAtUNvyItUV9Ci+ QKdef1MDocf52wwGb60toeFdkXFjRnZJRKcsoRBTpq44x2ULtzWDrLa42PG+HHszh9rp LjIg== X-Forwarded-Encrypted: i=1; AJvYcCWrU+lXLpqiaaRzem4jqD9vtLihDDiBytX2M9qL4mSOHcGzIQvwtsDOAAKK00ZCVZgMGMJcAisA7qM=@vger.kernel.org X-Gm-Message-State: AOJu0YwSXcSkALK3q7u4XU08uS9Lj0J2jg9aUzBMYrhdQRnvdTUCObI9 5OVIdoGWriZCcZZ2y7p1CsnUtSifQKnO+VylJhv0xkuJOqLRiprv2NgSoKN2gg9tFtAp8qJPNpF S X-Google-Smtp-Source: AGHT+IHMRW3LKj7hVd13fw0NA8R8RK3iFhWEx0wtfxCzkNV7xvC+GUbQfnGNOuOyF4KN9HvNqZ7bTA== X-Received: by 2002:a05:651c:b0a:b0:2fb:591d:3de1 with SMTP id 38308e7fff4ca-2fcbe0c1d42mr30158671fa.7.1730373207464; Thu, 31 Oct 2024 04:13:27 -0700 (PDT) Received: from [192.168.1.4] (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2fdef61837dsm1875871fa.70.2024.10.31.04.13.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Oct 2024 04:13:26 -0700 (PDT) Message-ID: Date: Thu, 31 Oct 2024 13:13:24 +0200 Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 -next] i2c: qcom-cci: Remove the unused variable cci_clk_rate Content-Language: en-US To: Andi Shyti , Jiapeng Chong Cc: loic.poulain@linaro.org, rfoss@kernel.org, linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Abaci Robot References: <20241029020931.42311-1-jiapeng.chong@linux.alibaba.com> From: Vladimir Zapolskiy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Andi, On 10/31/24 12:44, Andi Shyti wrote: > Hi Jiapeng, > > On Tue, Oct 29, 2024 at 10:09:31AM +0800, Jiapeng Chong wrote: >> Variable ret is not effectively used, so delete it. >> >> drivers/i2c/busses/i2c-qcom-cci.c:526:16: warning: variable ‘cci_clk_rate’ set but not used. >> >> Reported-by: Abaci Robot >> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11532 >> Signed-off-by: Jiapeng Chong > > thanks for your patch! Applied to i2c/i2c-host > > Thanks, > Andi > FWIW I've noticed that my Reviewed-by tag was added to the accepted change, while it was the conditional one... Actually I don't know how to be aware of such nuances, if only b4 tool is used, likely there is no way for it. Hopefully I'm not too picky with it. -- Best wishes, Vladimir