From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 861C533507A for ; Tue, 28 Oct 2025 17:45:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761673542; cv=none; b=BHPR8lTmQAc1Uw/xeeqwZeJmgb1S9fZkuvVfiRlXYcuC/UjdjqIisk/eK6n8/m3O845dv4QebskeRO0y54tLKbEzIXDB2q5iY0zP7953qs0wURoPAepUB6+YmmChLpm2Sb/rVUkvMcojpk5bCsn2nhvdvhUTPZlxX/irwfdxNbY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761673542; c=relaxed/simple; bh=dPTAqo94yX4yLEWIUeLeFRZwJxE6rHIbjG+u46l/2+E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RXTyewKAeGKykB/0pfqx1W3LmIgVAF30u2GilwkcyMgr5yG2wdo5de2xPg3EbdyJnMvRY0D89Tjw8zyttCSDiyn56sWSwkoK8bPoRD789Y7dsLHEFF1xcqTghju7YDBX4ZegtJZyfjq0C7ci4vTEpeGO7yubC7n5+fM3h8wM1Kg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gZB6EN7B; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=U1bBAylN; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gZB6EN7B"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="U1bBAylN" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 59SEniEU1974268 for ; Tue, 28 Oct 2025 17:45:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xkA/zkpVLFM+Q+17lYEFpBMLDdR9dMCKrvOWUVCL/dU=; b=gZB6EN7B5M+vygTh u3bk+LV1sypM4bd2SOPuDqPiydmibAcs2F+LlSxvp0vmOwsbhA/PQWq5OIwYDoNB GMc1JfN8SOsCXZn/0D9U5hLvFC6HdityRZUadxCEokauKrpQNj2nnFYeDGld77Vb 69/ftCgq8Jk42NHo8yCRSQsRVNtYJoFzKxa4vd7/6R1xYv6Z6ORSnAq73xoD4hMn Pk4BQXbEAtKTbA34PVB94/dwyl5i35W5sFjhS3cw9mjhoaq2zjiWh67ogEccTTCt /hyOm0uG1Gd6JohjTEyovkCOkKx94iON+1Fqta4YJewYCn+VPR8d2XPZRNTHkdnU nTDkUg== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a2pgeadmq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 28 Oct 2025 17:45:39 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-32ee157b9c9so4820655a91.2 for ; Tue, 28 Oct 2025 10:45:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1761673539; x=1762278339; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xkA/zkpVLFM+Q+17lYEFpBMLDdR9dMCKrvOWUVCL/dU=; b=U1bBAylNZMERK6gWSnx5Q9nZi4JuGGrWbioKPaa30/mhXenA1fKpUCg/MXakATiLUq 7hAa/GRZNcG396QAuoMDuvimM8+kuGgrEo/EO2NTXJwjp+m8PPccqSpaugEJR7aigNeF iZAtHGagL0gIGcjzAUZ6N6jRf0u8ZxoYJKAD3gI4Ahew4TC67XrSnRI1PsL7mRktcSg8 L/epmQ3WBvuT7cg9B82259L6DRRa2hfmMqt6FIiP2iXR784v0+oW3VaqtMAGAk3sVEv/ uL+wIRZS8nYagjwoWjv6uADKiVHoRxBFIAa1iUc5+EeP+w8Wuwv2CSK3QWS9Ec3kZKvA u4aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761673539; x=1762278339; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xkA/zkpVLFM+Q+17lYEFpBMLDdR9dMCKrvOWUVCL/dU=; b=eJRi31JmP7wwMlNULKtc8pjGd5b+OrO68VZNnqajzw1KfSo7NYBt2UmFZfR0/zcMIi P/l53AmINRERgNQKm/PFG5GH9CtL5VncSIkEIrGpqd4REjPkQF6vdZd9nR6ukvpBlIvO 2Gn5Wubq2S0Pumuaat+VZA3Ef6SzSh45PgG5KBN47lTb8Be4PDC+1Ea23n4MhIma0aXG tsme+WptYcb2ODYwcF/eWF0hX22ryP+/C/tX3ve9vGdA252/OKYk0vGSnpuOv1tVLMa4 OyeQwfdYTTBUfbkg6lETj2zV4vEcvMp5JwE8HC5Z9WVKKdJDiNt4W5L0qZ31JU8ctbS+ KidA== X-Forwarded-Encrypted: i=1; AJvYcCUJF34Amn6EDthPVL5JFBH7kIedh6fZMwsqZeBqEA4xbOEv2hjXlIWUWfopuGtNuRNNEVrqsOOlanE=@vger.kernel.org X-Gm-Message-State: AOJu0YwxywkEnqHmiC5WapZEg9ScvNWsBUX8bdaEmCaXUqt/fHJML6Kw 7gYfk/gGF7Wtum38PPbRb45MBB98uKTTNJzf4YfpITKPNx/w9buBXMeNVW66VYEnrCzEL1GXc/Q HN5eAy28UWRuRbzvmJjj9MldukOzyee2mt1Fv99Dy7lCT83bPQuoDZOP/Mq+6R88= X-Gm-Gg: ASbGnctzYmwrOif72zAplyzMtfTlCNL+N0Xm2I8eBQp5wilzYiKhgdTzYS1dwYtzv2p Eoq4zZtMTEK0pvtkb2q/8UIJmlfgNtO6DcOKnY5YOMhvLg3n9lDJwlWprG29JXgq4d7ZCDZMeO7 fPaOTqcjPa/mjFEhETHMZRWXchYDwV2Un7ZIG2ipmJ/Kt2Y1jX7PlrNZOlYG9oH5fIoIvqj8Q3E VuxHVe6NJJY1yCFuSFY2cRvL4TWqRjQkjeS6yq7QFwnczizZe8O33aMs4X0xDbaM+11Ct+SIO9E n6nkWhDuez7vpD6EFD59p0bD1Fd1zoNkIzVXulSE6Vyk8SMtA3p2YkAylq6k8XIUW4YHZvgmjXo E5Lg8jrtb4EIvA53C94jQnJMyjsFjxainzsEOEIFD2O6zAaC3pPooWg== X-Received: by 2002:a17:90b:4f48:b0:32e:d599:1f66 with SMTP id 98e67ed59e1d1-34027aa6fcdmr4760712a91.30.1761673538971; Tue, 28 Oct 2025 10:45:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHuQ4oB8lAaFLm026v9WNoqkcgU7WEfxHuzAXo3vj1uF6CO0bDjhoKRGXcHBKJ0X96hMLQfHA== X-Received: by 2002:a17:90b:4f48:b0:32e:d599:1f66 with SMTP id 98e67ed59e1d1-34027aa6fcdmr4760647a91.30.1761673538288; Tue, 28 Oct 2025 10:45:38 -0700 (PDT) Received: from [10.62.37.19] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-33fed80aa48sm12829058a91.13.2025.10.28.10.45.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Oct 2025 10:45:37 -0700 (PDT) Message-ID: Date: Tue, 28 Oct 2025 10:45:35 -0700 Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/6] dt-bindings: media: camss: Add qcom,kaanapali-camss binding To: Krzysztof Kozlowski , Hangxiang Ma Cc: Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab , Bryan O'Donoghue , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com, Jingyi Wang , Atiya Kailany References: <20251023-add-support-for-camss-on-kaanapali-v3-0-02abc9a107bf@oss.qualcomm.com> <20251023-add-support-for-camss-on-kaanapali-v3-2-02abc9a107bf@oss.qualcomm.com> <20251028-wonderful-olive-muskox-77f98d@kuoka> <7efc63ed-9c84-43c0-b524-f7e9e60b2846@kernel.org> Content-Language: en-US From: Vijay Kumar Tumati In-Reply-To: <7efc63ed-9c84-43c0-b524-f7e9e60b2846@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: LzdRVafAPGBl_DzAmslT1NJyhuAG38dm X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDI4MDE1MCBTYWx0ZWRfX/B1RWmD/XiLU mAhk8eLQWNHX7ginrx5KBYYxcaqRmMWQYg0SW/4P8Tq7i4uw2tQ92Je4CGhq7NgvvS9JqfOIcMa Ko1Vb1zuzLW+PUSc/KxtteNdDCZauAzREAoAtnjCdSNIWjEnhLH7BgG/Ids45ie1nLbvM2wJBpk fByR8I11WH9APvUGoWMfEkNJTjzLvOhwIgCkWZEmHIy/VrENTHA4zyFJHKVE0ld67zTiomg5g0l NbQ5XdGsu3F+SJtvzIhEZ5ChIy3dixsni4oP+48P81Bs9LlioBCaGdci9Y3gP/uFZG9VHI69AfD DuHTJYsQp7VQ7QBIsYyCvzbXvOH+V2hM7FUY3n9u2UP4B2xyYVug367gJvfiUBzRiA+sdrKNDr6 y5qUpmeXAsjNxhVVxfT+Ie6V1BF4CA== X-Proofpoint-GUID: LzdRVafAPGBl_DzAmslT1NJyhuAG38dm X-Authority-Analysis: v=2.4 cv=fLU0HJae c=1 sm=1 tr=0 ts=69010143 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=7CHmgrWEnh46U9yic0UA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-28_06,2025-10-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 spamscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510020000 definitions=main-2510280150 On 10/28/2025 9:56 AM, Krzysztof Kozlowski wrote: > On 28/10/2025 16:22, Vijay Kumar Tumati wrote: >>>> + interconnects: >>>> + maxItems: 2 >>>> + >>>> + interconnect-names: >>>> + items: >>>> + - const: ahb >>>> + - const: hf_mnoc >>> Why previously this was called hf_0 but now hf? >> Hi Krzysztof, the interconnect driver exposes only one node 'camnoc_hf' > Drivers don't matter. Interconnect driver does not matter here. You > describe this hardware, not interconnect driver. > > Keep it consistent with previous devices, whichever these are. There has been a mixed usage in the previous devices but this (hf) is consistent with the recently added ones, like x1e80100 and 2290. > >> to the camera driver, with it internally managing the voting on hf_0 and >> hf_1 clients. The traffic from the Real Time blocks in camera go through >> both HF_0 and HF_1, with the former being the primary. This change >> correctly represents that the BW voting is for the whole of the HF >> client. Please let me know if you have any further questions and we >> would be happy to answer. Thank you. >>>> + >>>> + iommus: >>>> + maxItems: 1 >>>> + >>>> + power-domains: >>>> + items: >>>> + - description: >>>> + TFE0 GDSC - Thin Front End, Global Distributed Switch Controller. >>>> + - description: >>>> + TFE1 GDSC - Thin Front End, Global Distributed Switch Controller. >>>> + - description: >>>> + TFE2 GDSC - Thin Front End, Global Distributed Switch Controller. >>>> + - description: >>>> + Titan GDSC - Titan ISP Block Global Distributed Switch Controller. >>>> + >>>> + power-domain-names: >>>> + items: >>>> + - const: tfe0 >>>> + - const: tfe1 >>>> + - const: tfe2 >>> Why not using the same names as before? It really does not matter that >>> it is thin or image, all of them are the same because only the >>> difference against top matters. >> Right, this is done to maintain the consistency with the clock driver on > Sorry, this makes no sense. This device has nothing to do with clock > driver. Don't ever use clock drivers as arguments for doing something in > completely different place. > > Not mentioning that drivers don't matter much for the bindings, so I > really do not get what you try to explain here. Understood. I meant to say that it is consistent with the naming for the TFE device that is available on Kaanapali. If our intention is to keep the names in the bindings same as previous generations despite the changing HW architectures, we could change these to IFEs, to be consistent with previous  generations. Please advise. Appreciate your inputs here. > > Best regards, > Krzysztof