From: Eric Miao <eric.y.miao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Uwe Kleine-König"
<u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>,
Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
Russell King <rmk+kernel-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Roel Kluin <roel.kluin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
Subject: Re: [PATCH 2/2 RESENT] [ARM] i2c/pxa: only define 'blue_murder'-function if DEBUG is #defined
Date: Mon, 9 Nov 2009 16:58:03 +0800 [thread overview]
Message-ID: <f17812d70911090058n4018619p617defe79f43b9d8@mail.gmail.com> (raw)
In-Reply-To: <1257754721-17325-2-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2009/11/9 Uwe Kleine-König <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>:
> From: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
>
> This talkative function is also called on timeouts. As timeouts can
> happen on regular writes to EEPROMs (no error case), this creates false
> positives. Giving lots of details is interesting only for developers
> anyhow, so just use the function if DEBUG is #defined.
>
Well, this does look cleaner. Feel free to take my Ack.
next prev parent reply other threads:[~2009-11-09 8:58 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 19:03 [PATCH 1/2] [ARM] i2c/pxa: remove unused macro Uwe Kleine-König
[not found] ` <1257275000-18866-1-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2009-11-03 19:03 ` [PATCH 2/2] [ARM] i2c/pxa: only define 'blue_murder'-function if DEBUG is #defined Uwe Kleine-König
2009-11-03 19:06 ` [PATCH 1/2] [ARM] i2c/pxa: remove unused macro Pavel Machek
2009-11-03 20:00 ` Uwe Kleine-König
2009-11-03 21:01 ` Russell King
[not found] ` <20091103210115.GA24955-f404yB8NqCZvn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2009-11-03 22:12 ` Ben Dooks
[not found] ` <20091103221249.GI13398-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2009-11-04 19:06 ` Russell King - ARM Linux
2009-11-04 9:00 ` Uwe Kleine-König
2009-11-03 22:13 ` Ben Dooks
2009-11-09 8:18 ` [PATCH 1/2 RESENT] " Uwe Kleine-König
[not found] ` <1257754721-17325-1-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2009-11-09 8:18 ` [PATCH 2/2 RESENT] [ARM] i2c/pxa: only define 'blue_murder'-function if DEBUG is #defined Uwe Kleine-König
[not found] ` <1257754721-17325-2-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2009-11-09 8:58 ` Eric Miao [this message]
2009-11-19 19:15 ` [PATCH 1/2 RESEND#2] i2c/pxa: remove unused macro Uwe Kleine-König
[not found] ` <1258658141-30340-1-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2009-11-19 19:15 ` [PATCH 2/2 RESEND#2] i2c/pxa: only define 'blue_murder'-function if DEBUG is #defined Uwe Kleine-König
[not found] ` <1258658141-30340-2-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-02-24 11:00 ` my i2c-patches for 2.6.34 Uwe Kleine-König
[not found] ` <20100224110044.GB15181-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-02-24 11:01 ` [PATCH 1/3] i2c/pxa: remove unused macro Uwe Kleine-König
[not found] ` <1267009306-17227-1-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-03-22 21:04 ` Uwe Kleine-König
[not found] ` <20100322210411.GD10157-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-03-22 21:54 ` Roel Kluin
2010-02-24 11:01 ` [PATCH 2/3] i2c/pxa: only define 'blue_murder'-function if DEBUG is #defined Uwe Kleine-König
[not found] ` <1267009306-17227-2-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-02-28 15:55 ` Russell King - ARM Linux
[not found] ` <20100228155502.GB16745-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2010-03-22 21:02 ` Uwe Kleine-König
2010-04-18 13:22 ` Wolfram Sang
[not found] ` <20100418132251.GB21364-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-04-18 13:45 ` Russell King - ARM Linux
[not found] ` <20100418134502.GA15452-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2010-04-18 14:05 ` Wolfram Sang
[not found] ` <20100418140548.GC21364-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-04-18 14:11 ` Pavel Machek
2010-02-24 11:01 ` [PATCH 3/3] MAINTAINERS: add i2c tree for embedded platforms Uwe Kleine-König
[not found] ` <1267009306-17227-3-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-02-28 15:57 ` Russell King - ARM Linux
[not found] ` <20100228155754.GC16745-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2010-03-01 9:07 ` Uwe Kleine-König
[not found] ` <20100301090714.GB29952-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-03-01 10:38 ` Jean Delvare
[not found] ` <20100301113840.4d6b4e7d-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2010-03-01 11:12 ` [PATCH] " Uwe Kleine-König
[not found] ` <1267441936-4432-1-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-03-22 21:03 ` Uwe Kleine-König
2009-11-26 10:44 ` [PATCH 1/2 RESEND#2] i2c/pxa: remove unused macro Uwe Kleine-König
2009-12-08 21:18 ` Uwe Kleine-König
[not found] ` <20091208211810.GB13706-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2009-12-08 21:44 ` Jean Delvare
2009-12-08 22:07 ` Uwe Kleine-König
[not found] ` <20091208220724.GA14696-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2009-12-09 8:11 ` Jean Delvare
[not found] ` <20091209091146.78e8d7bb-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-12-16 13:46 ` Uwe Kleine-König
2010-01-12 10:58 ` Uwe Kleine-König
[not found] ` <20100112105846.GA31145-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-01-25 9:28 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f17812d70911090058n4018619p617defe79f43b9d8@mail.gmail.com \
--to=eric.y.miao-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pavel-+ZI9xUNit7I@public.gmane.org \
--cc=rmk+kernel-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=roel.kluin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).