From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Miao Subject: Re: [PATCH 2/2 RESENT] [ARM] i2c/pxa: only define 'blue_murder'-function if DEBUG is #defined Date: Mon, 9 Nov 2009 16:58:03 +0800 Message-ID: References: <1257275000-18866-1-git-send-email-u.kleine-koenig@pengutronix.de> <1257754721-17325-1-git-send-email-u.kleine-koenig@pengutronix.de> <1257754721-17325-2-git-send-email-u.kleine-koenig@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1257754721-17325-2-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Wolfram Sang , Jean Delvare , Ben Dooks , Russell King , Roel Kluin , Pavel Machek List-Id: linux-i2c@vger.kernel.org 2009/11/9 Uwe Kleine-K=C3=B6nig : > From: Wolfram Sang > > This talkative function is also called on timeouts. As timeouts can > happen on regular writes to EEPROMs (no error case), this creates fal= se > positives. =C2=A0Giving lots of details is interesting only for devel= opers > anyhow, so just use the function if DEBUG is #defined. > Well, this does look cleaner. Feel free to take my Ack.