From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Subject: Re: [PATCH i2c-next v6] i2c: aspeed: Handle master/slave combined irq events properly Date: Wed, 12 Sep 2018 07:57:24 +0200 Message-ID: References: <20180823225731.19063-1-jae.hyun.yoo@linux.intel.com> <20180911183734.GA21976@roeck-us.net> <1f34fe8c-69ef-5f2d-25dc-d5f6037cc558@linux.intel.com> <20180911204107.GA26017@roeck-us.net> <20180911233302.GA18799@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180911233302.GA18799@roeck-us.net> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Guenter Roeck , Joel Stanley Cc: Jae Hyun Yoo , linux-aspeed@lists.ozlabs.org, Vernon Mauery , OpenBMC Maillist , Brendan Higgins , Linux Kernel Mailing List , jarkko.nikula@linux.intel.com, James Feist , Linux ARM , linux-i2c@vger.kernel.org List-Id: linux-i2c@vger.kernel.org T24gMDkvMTIvMjAxOCAwMTozMyBBTSwgR3VlbnRlciBSb2VjayB3cm90ZToKPiBPbiBXZWQsIFNl cCAxMiwgMjAxOCBhdCAwODoyMzoyOUFNICswOTMwLCBKb2VsIFN0YW5sZXkgd3JvdGU6Cj4+IE9u IFdlZCwgMTIgU2VwIDIwMTggYXQgMDc6NDgsIEphZSBIeXVuIFlvbyA8amFlLmh5dW4ueW9vQGxp bnV4LmludGVsLmNvbT4gd3JvdGU6Cj4+Pgo+Pj4gT24gOS8xMS8yMDE4IDE6NDEgUE0sIEd1ZW50 ZXIgUm9lY2sgd3JvdGU6Cj4+Pj4gT24gVHVlLCBTZXAgMTEsIDIwMTggYXQgMDE6MzA6NDFQTSAt MDcwMCwgSmFlIEh5dW4gWW9vIHdyb3RlOgo+Pgo+Pj4+PiBJIGNoZWNrZWQgdGhpcyBwYXRjaCBh Z2FpbiBidXQgaXQgZG9lc24ndCBoYXZlIGFueSBjaGFuZ2UgdGhhdCBjb3VsZAo+Pj4+PiBhZmZl Y3QgdG8gdGhlIHByb2JpbmcgZmxvdy4gSSdsbCBkZWJ1ZyB0aGUgaXNzdWUgb24gcWVtdSAzLjAg ZW52aXJvbm1lbnQKPj4+Pj4gYW5kIHdpbGwgc2hhcmUgaWYgSSBmaW5kIHNvbWV0aGluZy4KPj4+ Pj4KPj4+PiBUaGUgcHJvYmxlbSBtYXkgYmUgdGhhdCBxZW11IGFuZCB0aGUgbmV3IGNvZGUgZGlz YWdyZWUgaG93IGludGVycnVwdHMKPj4+PiBzaG91bGQgYmUgZ2VuZXJhdGVkIGFuZCBoYW5kbGVk LCBhbmQgdGhlIG5ldyBjb2RlIGRvZXMgbm90IGhhbmRsZSB0aGUKPj4+PiBpbnRlcnJ1cHRzIGl0 IHJlY2VpdmVzIGZyb20gdGhlIHNpbXVsYXRlZCBoYXJkd2FyZS4gVGhpcyB3aWxsIHJlc3VsdAo+ Pj4+IGluIGkyYyBkZXZpY2UgcHJvYmUgZmFpbHVyZSwgd2hpY2ggaW4gdHVybiBjYW4gY2F1c2Ug YWxsIGtpbmRzIG9mCj4+Pj4gcHJvYmxlbXMuCj4+Pj4KPj4+Cj4+PiBZZXMsIHRoYXQgbWFrZXMg c2Vuc2UuIExvb2tzIGxpa2UgaXQgc2hvdWxkIGJlIHJldmVydGVkIHVudGlsIHRoZSBpc3N1ZQo+ Pj4gaXMgZml4ZWQuIFdpbGwgc3VibWl0IGEgcGF0Y2ggdG8gcmV2ZXJ0IGl0Lgo+Pgo+PiBMZXQn cyBub3QgcnVzaC4gVGhlIHFlbXUgbW9kZWwgd2FzIHdyaXR0ZW4gaW4gb3JkZXIgdG8gYWxsb3cg dXMgdG8KPj4gdGVzdCB0aGUga2VybmVsIGNvZGUsIGFuZCB3YXMgdmFsaWRhdGVkIGJ5IHRoZSBr ZXJuZWwgZHJpdmVyIHdlIGhhdmUuCj4+IFdlJ3ZlIGhhZCBzaXR1YXRpb25zIGluIHRoZSBwYXN0 ICh3aXRoIHRoZSBpMmMgZHJpdmVyIGluIGZhY3QpIHdoZXJlIGEKPj4gY2hhbmdlIGluIHRoZSBk cml2ZXIgcmVxdWlyZWQgYW4gdXBkYXRlIG9mIHRoZSBtb2RlbCB0byBiZSBtb3JlCj4+IGFjY3Vy YXRlLgo+Pgo+PiBJIHN1Z2dlc3Qgd2Ugd2FpdCB1bnRpbCBDZWRyaWMgaGFzIGEgY2hhbmNlIHRv IGxvb2sgYXQgdGhlIGlzc3VlCj4+IGJlZm9yZSByZXZlcnRpbmcgdGhlIHBhdGNoLgo+Pgo+IAo+ IExvb2tpbmcgaW50byB0aGUgcGF0Y2gsIGNsZWFyaW5nIHRoZSBpbnRlcnJ1cHQgc3RhdHVzIGF0 IHRoZSBlbmQgb2YgYW4KPiBpbnRlcnJ1cHQgaGFuZGxlciBpcyBhbHdheXMgc3VzcGljaW91cyBh bmQgdGVuZHMgdG8gcmVzdWx0IGluIHJhY2UKCnllcy4gVGhhdCBoYXBwZW5lZCBpbiB0aGUgcGFz dCB3aXRoIHRoZSBJMkMgYXNwZWVkIGRyaXZlci4gSSBjYW4gbm90IGZpbmQKdGhlIHRocmVhZCBh bnltb3JlIGJ1dCB3ZSBoYWQgdG8gbW92ZSB1cCB0aGUgYWNrIG9mIHRoZSBpbnRlcnJ1cHRzLiAK ClFFTVUgdGVuZHMgdG8gYmUgbXVjaCBmYXN0ZXIgdG8gZmlyZSBpbnRlcnJ1cHRzIHRoYW4gcmVh bCBIVy4KCgo+IGNvbmRpdGlvbnMgKGJlY2F1c2UgYWRkaXRpb25hbCBpbnRlcnJ1cHRzIG1heSBo YXZlIGFycml2ZWQgd2hpbGUgaGFuZGxpbmcKPiB0aGUgZXhpc3RpbmcgaW50ZXJydXB0cywgb3Ig YmVjYXVzZSBpbnRlcnJ1cHQgaGFuZGxpbmcgaXRzZWxmIG1heSB0cmlnZ2VyCj4gYW5vdGhlciBp bnRlcnJ1cHQpLiBXaXRoIHRoYXQgaW4gbWluZCwgdGhlIGZvbGxvd2luZyBwYXRjaCBmaXhlcyB0 aGUKPiBwcm9ibGVtIGZvciBtZS4KCkFja2VkLWJ5OiBDw6lkcmljIExlIEdvYXRlciA8Y2xnQGth b2Qub3JnPgoKVGhhbmtzLAoKQy4KCj4gR3VlbnRlcgo+IAo+IC0tLQo+IAo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2kyYy9idXNzZXMvaTJjLWFzcGVlZC5jIGIvZHJpdmVycy9pMmMvYnVzc2VzL2ky Yy1hc3BlZWQuYwo+IGluZGV4IGMyNThjNGQ5YTRjMC4uYzQ4OGU2OTUwYjdjIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvaTJjL2J1c3Nlcy9pMmMtYXNwZWVkLmMKPiArKysgYi9kcml2ZXJzL2kyYy9i dXNzZXMvaTJjLWFzcGVlZC5jCj4gQEAgLTU1Miw2ICs1NTIsOCBAQCBzdGF0aWMgaXJxcmV0dXJu X3QgYXNwZWVkX2kyY19idXNfaXJxKGludCBpcnEsIHZvaWQgKmRldl9pZCkKPiAgCj4gIAlzcGlu X2xvY2soJmJ1cy0+bG9jayk7Cj4gIAlpcnFfcmVjZWl2ZWQgPSByZWFkbChidXMtPmJhc2UgKyBB U1BFRURfSTJDX0lOVFJfU1RTX1JFRyk7Cj4gKwkvKiBBY2sgYWxsIGludGVycnVwdCBiaXRzLiAq Lwo+ICsJd3JpdGVsKGlycV9yZWNlaXZlZCwgYnVzLT5iYXNlICsgQVNQRUVEX0kyQ19JTlRSX1NU U19SRUcpOwo+ICAJaXJxX3JlbWFpbmluZyA9IGlycV9yZWNlaXZlZDsKPiAgCj4gICNpZiBJU19F TkFCTEVEKENPTkZJR19JMkNfU0xBVkUpCj4gQEAgLTU4NCw4ICs1ODYsNiBAQCBzdGF0aWMgaXJx cmV0dXJuX3QgYXNwZWVkX2kyY19idXNfaXJxKGludCBpcnEsIHZvaWQgKmRldl9pZCkKPiAgCQkJ ImlycSBoYW5kbGVkICE9IGlycS4gZXhwZWN0ZWQgMHglMDh4LCBidXQgd2FzIDB4JTA4eFxuIiwK PiAgCQkJaXJxX3JlY2VpdmVkLCBpcnFfaGFuZGxlZCk7Cj4gIAo+IC0JLyogQWNrIGFsbCBpbnRl cnJ1cHQgYml0cy4gKi8KPiAtCXdyaXRlbChpcnFfcmVjZWl2ZWQsIGJ1cy0+YmFzZSArIEFTUEVF RF9JMkNfSU5UUl9TVFNfUkVHKTsKPiAgCXNwaW5fdW5sb2NrKCZidXMtPmxvY2spOwo+ICAJcmV0 dXJuIGlycV9yZW1haW5pbmcgPyBJUlFfTk9ORSA6IElSUV9IQU5ETEVEOwo+ICB9Cj4gCgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo=