From: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, loic.poulain@linaro.org
Cc: rfoss@kernel.org, andi.shyti@kernel.org,
linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH v2 -next] i2c: qcom-cci: Remove the unused variable cci_clk_rate
Date: Wed, 30 Oct 2024 12:53:40 +0200 [thread overview]
Message-ID: <f5003f25-6a00-42f8-a130-5ce3c8761674@linaro.org> (raw)
In-Reply-To: <20241029020931.42311-1-jiapeng.chong@linux.alibaba.com>
On 10/29/24 04:09, Jiapeng Chong wrote:
> Variable ret is not effectively used, so delete it.
Variable ret is not deleted, the commit message is misleading.
> drivers/i2c/busses/i2c-qcom-cci.c:526:16: warning: variable ‘cci_clk_rate’ set but not used.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11532
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
With the needed change to the commit message:
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
--
Best wishes,
Vladimir
next prev parent reply other threads:[~2024-10-30 10:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 2:09 [PATCH v2 -next] i2c: qcom-cci: Remove the unused variable cci_clk_rate Jiapeng Chong
2024-10-29 14:34 ` Dmitry Baryshkov
2024-10-30 10:53 ` Vladimir Zapolskiy [this message]
2024-10-31 10:44 ` Andi Shyti
2024-10-31 11:13 ` Vladimir Zapolskiy
2024-10-31 11:35 ` Vladimir Zapolskiy
2024-10-31 11:41 ` Andi Shyti
2024-10-31 11:59 ` Vladimir Zapolskiy
2024-10-31 12:23 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5003f25-6a00-42f8-a130-5ce3c8761674@linaro.org \
--to=vladimir.zapolskiy@linaro.org \
--cc=abaci@linux.alibaba.com \
--cc=andi.shyti@kernel.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=rfoss@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox