From: Krzysztof Kozlowski <krzk@kernel.org>
To: Akhil R <akhilrajeev@nvidia.com>,
"andi.shyti@kernel.org" <andi.shyti@kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
Jon Hunter <jonathanh@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
"digetx@gmail.com" <digetx@gmail.com>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/3] dt-bindings: i2c: nvidia,tegra20-i2c: Specify the required properties
Date: Mon, 2 Jun 2025 13:18:43 +0200 [thread overview]
Message-ID: <f536ceb2-6794-4877-83d1-898e56840c0c@kernel.org> (raw)
In-Reply-To: <PH7PR12MB8178836F70C0A9F90121676EC062A@PH7PR12MB8178.namprd12.prod.outlook.com>
On 02/06/2025 13:10, Akhil R wrote:
>>
>>> + Module reset. This property is optional for controllers in Tegra194 and later
>>
>> Your binding says Tegra210 requires it, but 210 feels like something
>> later than 194. Maybe that's obvious for people knowing that device?
>
> Tegra210 is in fact an older device than T194. I will probably mention the chip names
> instead of “later” in the next version.
>
>>
>> Anyway, please wrap at 80 (see kernel coding style).
>
> Okay. Will update.
> checkpatch.pl don’t warn now till 100 characters. I thought it was updated.
Checkpatch is a tool, not coding style. Coding style document describes
the coding style.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-06-02 11:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-26 5:25 [PATCH v3 1/3] dt-bindings: i2c: nvidia,tegra20-i2c: Specify the required properties Akhil R
2025-05-26 5:25 ` [PATCH v3 2/3] i2c: tegra: make reset an optional property Akhil R
2025-05-26 5:25 ` [PATCH v3 3/3] i2c: tegra: Remove dma_sync_*() calls Akhil R
2025-05-26 5:40 ` [PATCH v3 1/3] dt-bindings: i2c: nvidia,tegra20-i2c: Specify the required properties Krzysztof Kozlowski
2025-05-26 5:48 ` Krzysztof Kozlowski
2025-05-26 9:03 ` Akhil R
[not found] ` <PH7PR12MB8178836F70C0A9F90121676EC062A@PH7PR12MB8178.namprd12.prod.outlook.com>
2025-06-02 11:18 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f536ceb2-6794-4877-83d1-898e56840c0c@kernel.org \
--to=krzk@kernel.org \
--cc=akhilrajeev@nvidia.com \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox