From: Peter Rosin <peda@axentia.se>
To: Phil Reid <preid@electromag.com.au>,
wsa@the-dreams.de, robh+dt@kernel.org, mark.rutland@arm.com,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/5] i2c: mux: pca954x: Add missing pca9542 definition to chip_desc
Date: Mon, 9 Jan 2017 08:55:13 +0100 [thread overview]
Message-ID: <f59d78b8-1d05-8751-2714-1bc90e8ad43f@axentia.se> (raw)
In-Reply-To: <1483589463-35380-2-git-send-email-preid@electromag.com.au>
On 2017-01-05 05:10, Phil Reid wrote:
> The spec for the pca954x was missing. This chip is the same as the pca9540
> except that it has interrupt lines. While the i2c_device_id table mapped
> the pca9542 to the pca9540 definition the compatible table did not. In
> preparation for irq support add the pca9542 definition.
>
> Signed-off-by: Phil Reid <preid@electromag.com.au>
Acked-by: Peter Rosin <peda@axentia.se>
Cheers,
peda
> ---
> drivers/i2c/muxes/i2c-mux-pca954x.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c b/drivers/i2c/muxes/i2c-mux-pca954x.c
> index dd18b9c..bbf088e 100644
> --- a/drivers/i2c/muxes/i2c-mux-pca954x.c
> +++ b/drivers/i2c/muxes/i2c-mux-pca954x.c
> @@ -84,6 +84,11 @@ struct pca954x {
> .enable = 0x4,
> .muxtype = pca954x_ismux,
> },
> + [pca_9542] = {
> + .nchans = 2,
> + .enable = 0x4,
> + .muxtype = pca954x_ismux,
> + },
> [pca_9543] = {
> .nchans = 2,
> .muxtype = pca954x_isswi,
> @@ -110,7 +115,7 @@ struct pca954x {
>
> static const struct i2c_device_id pca954x_id[] = {
> { "pca9540", pca_9540 },
> - { "pca9542", pca_9540 },
> + { "pca9542", pca_9542 },
> { "pca9543", pca_9543 },
> { "pca9544", pca_9544 },
> { "pca9545", pca_9545 },
> @@ -124,7 +129,7 @@ struct pca954x {
> #ifdef CONFIG_ACPI
> static const struct acpi_device_id pca954x_acpi_ids[] = {
> { .id = "PCA9540", .driver_data = pca_9540 },
> - { .id = "PCA9542", .driver_data = pca_9540 },
> + { .id = "PCA9542", .driver_data = pca_9542 },
> { .id = "PCA9543", .driver_data = pca_9543 },
> { .id = "PCA9544", .driver_data = pca_9544 },
> { .id = "PCA9545", .driver_data = pca_9545 },
>
next prev parent reply other threads:[~2017-01-09 7:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 4:10 [PATCH v2 0/5] i2c: mux: pca954x: Add interrupt controller support Phil Reid
2017-01-05 4:10 ` [PATCH v2 1/5] i2c: mux: pca954x: Add missing pca9542 definition to chip_desc Phil Reid
2017-01-09 7:55 ` Peter Rosin [this message]
2017-01-05 4:11 ` [PATCH v2 2/5] dt: bindings: i2c-mux-pca954x: Add documentation for interrupt controller Phil Reid
2017-01-05 4:11 ` [PATCH v2 3/5] i2c: mux: pca954x: Add interrupt controller support Phil Reid
[not found] ` <1483589463-35380-1-git-send-email-preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
2017-01-05 4:11 ` [PATCH v2 4/5] dt: bindings: i2c-mux-pca954x: Add documentation for i2c-mux-irq-mask-en Phil Reid
2017-01-05 4:11 ` [PATCH v2 5/5] i2c: mux: pca954x: Add irq_mask_en to delay enabling irqs Phil Reid
2017-01-09 7:54 ` Peter Rosin
[not found] ` <c5b2eeef-4501-e866-4bb3-f02ada7d4604-koto5C5qi+TLoDKTGw+V6w@public.gmane.org>
2017-01-09 9:04 ` Phil Reid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f59d78b8-1d05-8751-2714-1bc90e8ad43f@axentia.se \
--to=peda@axentia.se \
--cc=devicetree@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=preid@electromag.com.au \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).