From: Rustam Adilov <adilov@disroot.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>,
Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/8] i2c: rtl9300: introduce clk struct for upcoming rtl9607 support
Date: Mon, 23 Mar 2026 06:24:43 +0000 [thread overview]
Message-ID: <f7b43e8b7ea11cd222eabc2b61ee1888@disroot.org> (raw)
In-Reply-To: <c1c9b1e2-9add-42ea-b87a-c8d2c4f465f1@kernel.org>
On 2026-03-22 21:01, Krzysztof Kozlowski wrote:
> On 22/03/2026 13:34, Rustam Adilov wrote:
>> DEFINE_GUARD(rtl9300_i2c, struct rtl9300_i2c *, mutex_lock(&_T->lock), mutex_unlock(&_T->lock))
>> @@ -432,6 +436,10 @@ static int rtl9300_i2c_probe(struct platform_device *pdev)
>> if (ret)
>> return ret;
>>
>> + i2c->clk = devm_clk_get_optional_enabled(dev, NULL);
>
> Undocumented ABI at this point.
>
> Order your patches in correct order. First go bindings.
Will move the patch 7 to be before patch 5 in v4 of this patch series.
>> + if (IS_ERR(i2c->clk))
>> + return dev_err_probe(dev, PTR_ERR(i2c->clk), "Failed to enable i2c clock\n");
>> +
>> i = 0;
> Best regards,
> Krzysztof
Thanks,
Rustam
next prev parent reply other threads:[~2026-03-23 6:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-22 12:34 [PATCH v3 0/8] i2c: rtl9300: support for RTL9607C I2C controller Rustam Adilov
2026-03-22 12:34 ` [PATCH v3 1/8] i2c: rtl9300: split data_reg into read and write reg Rustam Adilov
2026-03-22 12:34 ` [PATCH v3 2/8] i2c: rtl9300: introduce max length property to driver data Rustam Adilov
2026-03-22 12:34 ` [PATCH v3 3/8] i2c: rtl9300: introduce F_BUSY to the reg_fields struct Rustam Adilov
2026-03-22 12:34 ` [PATCH v3 4/8] i2c: rtl9300: introduce a property for 8 bit width reg address Rustam Adilov
2026-03-22 12:34 ` [PATCH v3 5/8] i2c: rtl9300: introduce clk struct for upcoming rtl9607 support Rustam Adilov
2026-03-22 21:01 ` Krzysztof Kozlowski
2026-03-23 6:24 ` Rustam Adilov [this message]
2026-03-22 12:34 ` [PATCH v3 6/8] i2c: rtl9300: intoduce new function properties to driver data Rustam Adilov
2026-03-22 12:34 ` [PATCH v3 7/8] dt-bindings: i2c: realtek,rtl9301-i2c: extend for RTL9607C support Rustam Adilov
2026-03-22 21:02 ` Krzysztof Kozlowski
2026-03-23 6:21 ` Rustam Adilov
2026-03-22 12:34 ` [PATCH v3 8/8] i2c: rtl9300: add RTL9607C i2c controller support Rustam Adilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7b43e8b7ea11cd222eabc2b61ee1888@disroot.org \
--to=adilov@disroot.org \
--cc=andi.shyti@kernel.org \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox