From: Romain Porte <romain.porte@nokia.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, jdelvare@suse.de
Subject: Re: Patch proposal for risky i2c addresses in i2c-tools
Date: Mon, 29 Jan 2018 13:26:48 +0100 [thread overview]
Message-ID: <f81d1aa9-39c0-20d9-c4a4-4a00fd9b891f@nokia.com> (raw)
In-Reply-To: <20180126180330.3ep65ongfdgffbmu@ninjato>
Hello Wolfram,
On 26/01/2018 19:03, Wolfram Sang wrote:
> This handles only part of the risky addresses. I once worked on a device
> having an EEPROM using 32(!) addresses in the range from 0x00(!!)-0x1f.
> And yes, because it was the only device on the bus, that actually worked.
>
> So, the lower boundary should also be removed IMO.
Good to know, I will send a new patchset which takes the lower bound
into account.
> And I'd much prefer a flag like 'R' which represents 'risky' better.
I disagree here, the i2cdetect program is already using the '-a' option
for scanning risky addresses. I think we should keep consistency between
options and keep this option named '-a' for the other tools. As per
i2cdetect's man page:
-a Force scanning of non-regular addresses. Not recommended
Best regards,
Romain.
next prev parent reply other threads:[~2018-01-29 12:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 15:02 Patch proposal for risky i2c addresses in i2c-tools Romain Porte
2018-01-05 15:02 ` [PATCH 1/3] Add risky_addr option for i2c tools Romain Porte
2018-01-05 15:02 ` [PATCH 2/3] Update help message for risky_addr option Romain Porte
2018-01-05 15:02 ` [PATCH 3/3] Update man pages for risky_addr Romain Porte
2018-01-26 18:03 ` Patch proposal for risky i2c addresses in i2c-tools Wolfram Sang
2018-01-29 12:26 ` Romain Porte [this message]
2018-01-29 13:39 ` Peter Rosin
2018-01-29 12:40 ` New patchset for risky addr, with lower bound support Romain Porte
2018-01-29 12:40 ` [PATCH v2 1/3] Add risky_addr option for i2c tools Romain Porte
2018-01-29 12:40 ` [PATCH v2 2/3] Update help message for risky_addr option Romain Porte
2018-01-29 13:45 ` Peter Rosin
2018-01-29 12:40 ` [PATCH v2 3/3] Update man pages for risky_addr Romain Porte
2018-01-29 13:57 ` Patch proposal for risky addr, with updated help messages Romain Porte
2018-01-29 13:57 ` [PATCH v3 1/3] Add risky_addr option for i2c tools Romain Porte
2018-01-29 13:57 ` [PATCH v3 2/3] Update help message for risky_addr option Romain Porte
2018-01-29 13:57 ` [PATCH v3 3/3] Update man pages for risky_addr Romain Porte
2018-02-02 12:45 ` Patch proposal for using all addresses in i2c-tools Romain Porte
2018-02-02 12:45 ` [PATCH v4 1/3] Add all_addrs option for i2c tools Romain Porte
2018-02-02 12:45 ` [PATCH v4 2/3] Update help message for all_addrs option Romain Porte
2018-02-02 12:45 ` [PATCH v4 3/3] Update man pages for all_addrs Romain Porte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f81d1aa9-39c0-20d9-c4a4-4a00fd9b891f@nokia.com \
--to=romain.porte@nokia.com \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).