From: Akash Asthana <akashast@codeaurora.org>
To: Mark Brown <broonie@kernel.org>
Cc: gregkh@linuxfoundation.org, agross@kernel.org,
bjorn.andersson@linaro.org, wsa@the-dreams.de,
mark.rutland@arm.com, robh+dt@kernel.org,
georgi.djakov@linaro.org, linux-i2c@vger.kernel.org,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
swboyd@chromium.org, mgautam@codeaurora.org,
linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org,
mka@chromium.org, dianders@chromium.org, evgreen@chromium.org
Subject: Re: [PATCH V3 7/8] spi: spi-qcom-qspi: Add interconnect support
Date: Tue, 7 Apr 2020 15:24:42 +0530 [thread overview]
Message-ID: <f896d6e4-cc86-db46-a9b9-d7c98071b524@codeaurora.org> (raw)
In-Reply-To: <20200331112352.GB4802@sirena.org.uk>
Hi Mark,
On 3/31/2020 4:53 PM, Mark Brown wrote:
> On Tue, Mar 31, 2020 at 04:39:35PM +0530, Akash Asthana wrote:
>
>> + /*
>> + * Set BW quota for CPU as driver supports FIFO mode only.
>> + * Assume peak bw as twice of avg bw.
>> + */
>> + ctrl->avg_bw_cpu = Bps_to_icc(speed_hz);
>> + ctrl->peak_bw_cpu = Bps_to_icc(2 * speed_hz);
> I thought you were going to factor this best guess handling of peak
> bandwidth out into the core?
I can centralize this for SPI, I2C and UART in Common driver(QUP
wrapper) but still for QSPI I have to keep this piece of code as is
because It is not child of QUP wrapper(it doesn't use common code).
I am not sure whether I can move this " Assume peak_bw as twice of
avg_bw if nothing is mentioned explicitly" to ICC core because the
factor of 2 is chosen randomly by me.
Regards,
Akash
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project
next prev parent reply other threads:[~2020-04-07 9:55 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 11:09 [PATCH V3 0/8] Add interconnect support to QSPI and QUP drivers Akash Asthana
[not found] ` <1585652976-17481-1-git-send-email-akashast-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2020-03-31 11:09 ` [PATCH V3 1/8] interconnect: Add devm_of_icc_get() as exported API for users Akash Asthana
2020-03-31 11:09 ` [PATCH V3 6/8] tty: serial: qcom_geni_serial: Add interconnect support Akash Asthana
[not found] ` <1585652976-17481-7-git-send-email-akashast-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2020-03-31 19:39 ` Matthias Kaehlcke
2020-04-07 9:19 ` Akash Asthana
2020-04-07 9:40 ` Akash Asthana
2020-03-31 11:09 ` [PATCH V3 8/8] arm64: dts: sc7180: Add interconnect for QUP and QSPI Akash Asthana
2020-03-31 11:09 ` [PATCH V3 2/8] soc: qcom: geni: Support for ICC voting Akash Asthana
[not found] ` <1585652976-17481-3-git-send-email-akashast-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2020-03-31 17:52 ` Matthias Kaehlcke
[not found] ` <20200331175207.GG199755-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2020-04-02 13:46 ` Akash Asthana
2020-03-31 23:32 ` Bjorn Andersson
2020-04-01 16:26 ` Evan Green
2020-04-07 6:46 ` Akash Asthana
2020-04-07 9:58 ` Georgi Djakov
2020-04-08 11:13 ` Akash Asthana
2020-04-07 6:45 ` Akash Asthana
2020-04-07 22:07 ` Bjorn Andersson
2020-03-31 11:09 ` [PATCH V3 3/8] soc: qcom-geni-se: Add interconnect support to fix earlycon crash Akash Asthana
[not found] ` <1585652976-17481-4-git-send-email-akashast-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2020-03-31 18:24 ` Matthias Kaehlcke
[not found] ` <20200331182457.GH199755-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2020-04-01 19:46 ` Matthias Kaehlcke
2020-04-07 6:52 ` Akash Asthana
2020-04-07 11:34 ` Akash Asthana
2020-04-07 17:26 ` Matthias Kaehlcke
2020-04-08 11:38 ` Akash Asthana
2020-04-08 17:09 ` Matthias Kaehlcke
2020-03-31 11:09 ` [PATCH V3 4/8] i2c: i2c-qcom-geni: Add interconnect support Akash Asthana
[not found] ` <1585652976-17481-5-git-send-email-akashast-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2020-03-31 18:49 ` Matthias Kaehlcke
2020-04-07 7:04 ` Akash Asthana
2020-03-31 11:09 ` [PATCH V3 5/8] spi: spi-geni-qcom: " Akash Asthana
[not found] ` <1585652976-17481-6-git-send-email-akashast-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2020-03-31 19:02 ` Matthias Kaehlcke
2020-04-07 7:11 ` Akash Asthana
2020-03-31 11:09 ` [PATCH V3 7/8] spi: spi-qcom-qspi: " Akash Asthana
[not found] ` <1585652976-17481-8-git-send-email-akashast-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2020-03-31 11:23 ` Mark Brown
2020-04-07 9:54 ` Akash Asthana [this message]
2020-04-07 10:55 ` Mark Brown
2020-04-08 12:17 ` Akash Asthana
2020-04-09 13:17 ` Georgi Djakov
2020-04-09 13:20 ` Mark Brown
2020-04-15 10:34 ` Georgi Djakov
[not found] ` <eca0e6a7-effe-022c-e90e-c0672991251d@codeaurora.org>
2020-04-15 10:54 ` Georgi Djakov
2020-03-31 19:45 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f896d6e4-cc86-db46-a9b9-d7c98071b524@codeaurora.org \
--to=akashast@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=georgi.djakov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mgautam@codeaurora.org \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).