Re: Re: [PATCH] i2c: designware: Cleaning and comment style fixes.

[Luis Oliveira <Luis.Oliveira-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>]

On 13-Dec-16 17:00, Andy Shevchenko wrote:
> On Tue, 2016-12-13 at 16:34 +0000, Luis Oliveira wrote:
>> - Misspelling of some words
> 
> So, do you use codespell tool for that? I would suggest to use that tool
> and propose any fix there first. At least that tool has a good history
> of changes back in forward until some native speaker(s) settle some
> cases.
> 

I just fixed the words "acknowledgment" and "endianness" because checkpatch.pl
says it should be fixed.

>> - Comment format fix
> 
> No need to use dot at the end of one-liner comments
> 
> /* One line */
> 
> /*
>  * Multi-line comments. Might include several lines or
>  * even paragraphs.
>  */
> 
> Also I would leave 
> /*
>  * One line
>  */
> 
> Without dots here. AFAIU they are used to better distinguish group of
> definitions inside headers (that's why 3 lines).
> 

Ok thank you, I will go redo that.

>> - Minor fix in coding style
>>
> 
> I'm almost fine with the change itself, but people may be concerned in:
> 
> 1) what is the value of the change (would be nice to put this in commit
> message);
> 

The value of this, besides the Linux kernel rules of coding style, is because I
will use this code after and it will make my future patch a lot bigger and
complicated to review if I have to do it all together.

> 2) how much additional work this change may bring for backported fixes
> if any;
> 

I don't think there is any.

> 3) native speakers are the best who can re-read this and Ack.
> 


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html