From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9441C00528 for ; Tue, 25 Jul 2023 06:51:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231349AbjGYGvC (ORCPT ); Tue, 25 Jul 2023 02:51:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231187AbjGYGvC (ORCPT ); Tue, 25 Jul 2023 02:51:02 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B06EC8E for ; Mon, 24 Jul 2023 23:51:00 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-307d58b3efbso3876292f8f.0 for ; Mon, 24 Jul 2023 23:51:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690267859; x=1690872659; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=/7YC6gNPnD4sPdY6yeSLuPXwpQ68htwMP3OyMhq17Qw=; b=b5pyU0m3Xf8DtZUSpLNI5iWTtnR2JJRlLq1iYS83w/W8EiOdcfgsf/MSFvp9n/o4S9 vMNanaS/hwz7/UrzOHmHTHqTBK4DShBDSc7T3LAUyrbE2jiEmLnIaqLXIdWZAS9WTDsz UbOmtmzeeHLVGMLImoDkHDD3uo4inDfHi4lrUSCaQXBB3C8TrHInXZVmsNx2rBYpml3K DLoCy4g1woqdDNo6XY1CEAXBOtJLKlbS76jO/oUTRCIBQ577fXsMLwPUgmYLQ4Q253xH 2tTuRoKF5AIEqb0Bzm3t+MZ2n0hXFxCO85GsP0zGyEMyItTV1Qy34vGjCEN3+Fop/2Cs 8SAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690267859; x=1690872659; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/7YC6gNPnD4sPdY6yeSLuPXwpQ68htwMP3OyMhq17Qw=; b=WJ4Brf3sfdhPsYZwcGF5Ce6FvP5fpJSZ4kmz8RX57Negcsg4VIIyZODhjZ4wCqRBFT 0Rbl+QJ696Qeg2DS3+Kqhtmp0snbYOEIffBw7NWXa7taPn4sok/RpfNdzRghXDKZ7ErX sMk+tAYjJgppCo+K5itkl1OBBFHx/HzpUJBfM5ceU/MnID/wZJz0Ej73S3kSz2lqeGnv SyLm2WhAvIMZu5zAUnuK0XAr90XicigMSHp3xN/e3LYoKc3DfaYPvYVz1ZaeKxrstDLz 7xxwMmpm9kaAgh8jSn19uCCrH9X4730iTa69LPtLnXPNGGRJ/mNlrTydr3cBqFC+Bxtm 9tww== X-Gm-Message-State: ABy/qLY/LEAenSC9NN1Fdow3BF6Nx2nlHQgNa94QjVTEH/X3/KYxbI7g vGayMajKYKEvY1T3Z/jck6mkLA== X-Google-Smtp-Source: APBJJlHqNM99eb0ZHQXZM5f+65aTptDhOZEp2nsancdPfR1Rol7/vAlTqwOL6Py5w/39UVcsP6v7sA== X-Received: by 2002:adf:f591:0:b0:317:6efd:3a6b with SMTP id f17-20020adff591000000b003176efd3a6bmr199262wro.24.1690267859325; Mon, 24 Jul 2023 23:50:59 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id v1-20020a5d6781000000b0031434c08bb7sm15180817wru.105.2023.07.24.23.50.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jul 2023 23:50:58 -0700 (PDT) Date: Tue, 25 Jul 2023 09:50:55 +0300 From: Dan Carpenter To: Oleksij Rempel Cc: Pengutronix Kernel Team , Andi Shyti , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , linux-i2c@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] i2c: imx: Clean up a call to request_irq() Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org This is passing a NULL thread to request_threaded_irq(). So it's not really a threaded IRQ at all. It's more readable to call request_irq() instead. Signed-off-by: Dan Carpenter --- drivers/i2c/busses/i2c-imx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c index 65128a73e8a3..c0cac5bcfdd1 100644 --- a/drivers/i2c/busses/i2c-imx.c +++ b/drivers/i2c/busses/i2c-imx.c @@ -1506,8 +1506,7 @@ static int i2c_imx_probe(struct platform_device *pdev) goto rpm_disable; /* Request IRQ */ - ret = request_threaded_irq(irq, i2c_imx_isr, NULL, IRQF_SHARED, - pdev->name, i2c_imx); + ret = request_irq(irq, i2c_imx_isr, IRQF_SHARED, pdev->name, i2c_imx); if (ret) { dev_err(&pdev->dev, "can't claim irq %d\n", irq); goto rpm_disable; -- 2.39.2