From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH v3 0/5] i2c: i2c-mpc: make I2C bus speed configurable Date: Mon, 20 Apr 2009 07:26:14 -0600 Message-ID: References: <20090407082052.477328750@denx.de> <53B42D49-C040-442E-8448-7BC3190220A5@kernel.crashing.org> <49DC515F.3040100@grandegger.com> <49DD0144.7050902@grandegger.com> <49DDC718.8000706@grandegger.com> <49EC39D6.8020404@grandegger.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <49EC39D6.8020404@grandegger.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@ozlabs.org Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@ozlabs.org To: Wolfgang Grandegger Cc: Linux/PPC Development , devicetree-discuss , linux-i2c@vger.kernel.org, Ben Dooks List-Id: linux-i2c@vger.kernel.org On Mon, Apr 20, 2009 at 3:01 AM, Wolfgang Grandegger wr= ote: > Hi Ben, > > Wolfgang Grandegger wrote: >> Wolfgang Grandegger wrote: >>> Kumar Gala wrote: >>>> On Apr 8, 2009, at 2:25 AM, Wolfgang Grandegger wrote: >>>> >>>>>> So I'm a bit concerned with the output we now get: >>>>>> >>>>>> mpc-i2c fffe03000.i2c: clock 0 Hz (dfsrr=3D16 fdr=3D49) >>>>>> >>>>>> why 0? is that right? >>>>> This is the backward compatibility mode using hard-coded FDR values. = The >>>>> output is missleading, I agree. >>>>> >>>>> Wolfgang. >>>> Can the output be fixed. =A00 Hz seemed bad to me. >>> Of course. No info message will be printed for the legacy case >>> like it was with the old driver version. I just realized a bug in the >>> MPC52xx part. Will send patches tomorrow, after some more thorough test= ing. >> >> The patch below fixes both issues. Ben, could you please apply it. Sorry= for >> the inconvenience caused. >> >> Thanks, >> >> Wolfgang. >> >> >> >> [PATCH] i2c: i2c-mpc: bug fix for MPC52xx clock setting and printout >> >> The clock setting did not work for the MPC52xx due to a stupid bug. >> Furthermore, the dev info output "clock=3D0" for old device trees was >> misleading. This patch fixes both issues. >> >> Signed-off-by: Wolfgang Grandegger > > Could you please apply this bug-fix for the MPC driver for 2.6.30. Acked-by: Grant Likely > > =A0http://marc.info/?l=3Dlinux-i2c&m=3D123927120910293&w=3D2 > > Thanks, > > Wolfgang. > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@ozlabs.org > https://ozlabs.org/mailman/listinfo/linuxppc-dev > -- = Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.