From: Grant Likely <grant.likely@secretlab.ca>
To: "Piotr Zięcik" <kosmo@semihalf.com>
Cc: linuxppc-dev@ozlabs.org, Detlev Zundel <dzu@denx.de>,
Wolfgang Denk <wd@denx.de>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH 08/12] mpc5121: Added I2C support.
Date: Mon, 18 May 2009 08:11:30 -0600 [thread overview]
Message-ID: <fa686aa40905180711l5f85320n9508852f74f0b7b9@mail.gmail.com> (raw)
In-Reply-To: <200905181557.11766.kosmo@semihalf.com>
2009/5/18 Piotr Zięcik <kosmo@semihalf.com>:
>> Right. Furthermore, the i2c-mpc.c should be extened to support bus speed
>> setting for the MPC512x, which has been merged recently (see commit id
>> f2bd5efe).
>
> I have simple question about bus speed setting support. Existing
> implementation uses default safe speed if there is no 'clock-frequency'
> property in i2c node. Comments in code suggest that this behaviour is left
> for backward compatibility only. Should I make the 'clock-frequency'
> property mandatory for a new type of I2C controller (MPC5121) ?
yes. At least in documentation, but I wouldn't do extra work to
disable that behaviour for 5121 boards.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2009-05-18 14:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1241640919-4650-1-git-send-email-wd@denx.de>
[not found] ` <1241640919-4650-1-git-send-email-wd-ynQEQJNshbs@public.gmane.org>
2009-05-06 20:15 ` [PATCH 08/12] mpc5121: Added I2C support Wolfgang Denk
[not found] ` <1241640919-4650-9-git-send-email-wd-ynQEQJNshbs@public.gmane.org>
2009-05-06 21:01 ` Grant Likely
[not found] ` <fa686aa40905061401k319313c5q89fd3e245c30808f-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-05-06 22:19 ` Wolfgang Denk
2009-05-06 22:51 ` Grant Likely
[not found] ` <fa686aa40905061551l8cf5940sf4d4cbf34331cf9a-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-05-07 2:41 ` Grant Likely
[not found] ` <fa686aa40905061941p6fd4b03dt1097cf4d16bdd665-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-05-07 6:36 ` Wolfgang Grandegger
2009-05-18 13:57 ` Piotr Zięcik
2009-05-18 14:11 ` Grant Likely [this message]
[not found] ` <200905181557.11766.kosmo-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org>
2009-05-18 14:29 ` Wolfgang Grandegger
[not found] ` <4A1170B0.5080203-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2009-05-19 7:47 ` Piotr Zięcik
2009-05-19 8:10 ` Wolfgang Grandegger
2009-05-08 2:12 ` John Rigby
2009-05-08 3:01 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40905180711l5f85320n9508852f74f0b7b9@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=dzu@denx.de \
--cc=kosmo@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).