From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH 08/12] mpc5121: Added I2C support. Date: Mon, 18 May 2009 08:11:30 -0600 Message-ID: References: <1241640919-4650-1-git-send-email-wd@denx.de> <4A028182.3040107@grandegger.com> <200905181557.11766.kosmo@semihalf.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <200905181557.11766.kosmo@semihalf.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@ozlabs.org Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@ozlabs.org To: =?ISO-8859-2?Q?Piotr_Zi=EAcik?= Cc: linuxppc-dev@ozlabs.org, Detlev Zundel , Wolfgang Denk , linux-i2c@vger.kernel.org List-Id: linux-i2c@vger.kernel.org 2009/5/18 Piotr Zi=EAcik : >> Right. Furthermore, the i2c-mpc.c should be extened to support bus speed >> setting for the MPC512x, which has been merged recently (see commit id >> f2bd5efe). > > I have simple question about bus speed setting support. Existing > implementation uses default safe speed if there is no 'clock-frequency' > property in i2c node. Comments in code suggest that this behaviour is left > for backward compatibility only. Should I make the 'clock-frequency' > property mandatory for a new type of I2C controller (MPC5121) ? yes. At least in documentation, but I wouldn't do extra work to disable that behaviour for 5121 boards. g. -- = Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.