Re: [PATCH v7 0/4] i2c-mpc: add support for the Freescale MPC512x and other fixes

[Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>]

Ben D.,

These 4 patches are totally fine.  Do you want to pick them up, or
should I take them through the PowerPC tree?

Cheers,
g.

On Wed, Feb 10, 2010 at 7:55 AM, Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org> wrote:
> From: Wolfgang Grandegger <wg-ynQEQJNshbs@public.gmane.org>
>
> This patch series adds support for the MPC512x from Freescale to the
> i2c-mpc driver. At that occasion, issues with  __devinit[data] have
> been fixed and the doc of the FSL I2C dts bindings updated. It has
> been tested on a MPC5121ADS, TQM5200 and TQM8560 board
>
> Changes since v1:
>
> - use macro MPC_I2C_CLOCK_PRESERVE/SAFE for the special clock settings.
> - document the special DTS node "fsl,mpc5121-i2c-ctrl".
> - update and correct the Kconfig help.
> - some other minor fixes as suggested by Wolfram.
>
> Changes since v2:
>
> - use __init[data] instead of __devinit[data] for this driver.
>
> Changes since v3:
>
> - switch back to __devinit[data] as pointed out by Ben.
>
> Changes since v4:
>
> - check MPC_I2C_CLOCK_SAFE instead of "!clock" as suggested by Wolfram.
> - update MODULE_DESCRIPTION().
>
> Changes since v5 (suggested by Grant Likely):
>
> - various correctings for labling initialization functions and data
>  (this is tricky because section mismatches are not always obvious).
> - add a separate patch for renaming the setclock into setup functions.
> - correct the doc of the I2C bindings, e.g. don't mention the legacy
>  clock setting and remove obsolte parts.
>
> Changes since v6:
>
> - use __devinitconst for const data as suggested by Stephen Rothwell.
>
> Wolfgang
>
> Wolfgang Grandegger (4):
>  i2c-mpc: use __devinit[data] for initialization functions and data
>  i2c-mpc: rename "setclock" initialization functions to "setup"
>  i2c-mpc: add support for the MPC512x processors from Freescale
>  powerpc: doc/dts-bindings: update doc of FSL I2C bindings
>
>  Documentation/powerpc/dts-bindings/fsl/i2c.txt |   30 +++-
>  drivers/i2c/busses/Kconfig                     |    7 +-
>  drivers/i2c/busses/i2c-mpc.c                   |  194 +++++++++++++++---------
>  3 files changed, 146 insertions(+), 85 deletions(-)
>
> _______________________________________________
> devicetree-discuss mailing list
> devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
> https://lists.ozlabs.org/listinfo/devicetree-discuss
>



-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.