From: Petri Gynther <pgynther-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
To: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Cc: Greg Kroah-Hartman <greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] eeprom: add non-cached sysfs read access to EEPROM data
Date: Thu, 3 Sep 2009 11:42:53 -0700 [thread overview]
Message-ID: <fc21faff0909031142k35749556q3d79b72b034def44@mail.gmail.com> (raw)
In-Reply-To: <20090902221651.10b13a5b-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
OK, fine. I'll look into extending "at24" instead.
The only reason I was going with "eeprom" driver here is that it
worked just fine (with this diff) for my needs in 2.6.25. And, I
thought maybe someone else in the community can benefit from cache
bypass as well.
-- Petri
On Wed, Sep 2, 2009 at 1:16 PM, Jean Delvare<khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> wrote:
> On Wed, 2 Sep 2009 12:45:21 -0700, Petri Gynther wrote:
>> In 2.6.25, I used this patch successfully for read-only access to some
>> SFP EEPROMs:
>> - 0x50 - vendor/part info (caching OK)
>> - 0x51 - real-time diagnostics data (caching not OK)
>>
>> I only care about read-only access to these EEPROMs. And, actually, I
>> don't want to provide write access at all.
>>
>> In 2.6.31, I'd like to continue using this same legacy driver for SFP
>> EEPROM access, with the option of bypassing the cache.
>
> This is not going to happen, sorry. "eeprom" is a legacy driver and we
> certainly don't want to enhance it in any way. The "at24" driver is
> much easier to extend as it was designed that way from the ground up.
> You can add a SFP EEPROM type to it (whatever it is) and have the
> driver automatically set the access to read-only and the caching
> strategy for each part of the EEPROM.
>
> I'm curious, why do you insist on using the eeprom driver?
>
> --
> Jean Delvare
>
prev parent reply other threads:[~2009-09-03 18:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-01 23:15 [PATCH] eeprom: add non-cached sysfs read access to EEPROM data Petri Gynther
2009-09-01 23:39 ` Greg KH
[not found] ` <20090901233948.GA3828-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2009-09-02 19:28 ` Petri Gynther
2009-09-02 8:30 ` Jean Delvare
[not found] ` <20090902103034.15f13e4d-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-09-02 19:45 ` Petri Gynther
[not found] ` <fc21faff0909021245k44e27206t65a268470065431a-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-09-02 20:16 ` Jean Delvare
[not found] ` <20090902221651.10b13a5b-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-09-03 18:42 ` Petri Gynther [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc21faff0909031142k35749556q3d79b72b034def44@mail.gmail.com \
--to=pgynther-hpiqsd4aklfqt0dzr+alfa@public.gmane.org \
--cc=greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).