From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 269F4149C79; Tue, 9 Jul 2024 11:39:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.132.182.106 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720525184; cv=none; b=H0wK6Sn/Cqu5n/xXMcohMYUVAl03uznveh2mqlMba0j/hEqGKUqAhUptzrm2dpl7Jlbc/haGWtxtkacP+Br2CJWgdTuwcvdHQauiH4o+eOABxmKRFCBr79oHMjLYBHthFJSEfc9uoZaqdPeemr24Hy7c6/TWMtux5wpCGi3wZoA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720525184; c=relaxed/simple; bh=KVci1ewJpODW62ewI5aFL/oAb4URZ1RV8nCJ0WRK+78=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=QVXHUCbSGh3wECNFViF5V/DPF6e8NyvcxaZXGj6V3a+/5EUEiHwiKge+eP/wJkjCD2Hw+4hp4Ds2V1HEz75pnnYOBFo1d/Sk7VoLk7ZPocZmMbguimry8d2VWDfSXGI9FyX9fvCdkiZYAT/XJk6TZFkX89RUsGiqMhNRBPDkHGw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=kTy0qnxF; arc=none smtp.client-ip=185.132.182.106 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="kTy0qnxF" Received: from pps.filterd (m0369458.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 469B7D4Y026721; Tue, 9 Jul 2024 13:39:28 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=selector1; bh= VrCR8eqgNWUFIJOLFVkDypLDnbcb/OSRGgSpYoq94Z8=; b=kTy0qnxF3icqtIUx 2FkpwnDS2hror81CUqpf85XL6Q0THte+RgMuXNcQka/1H1BvnJMDf5jVeeSY7MNd puS3du3UDBUYq3lU7Hdv4288rRqpzwTyLOf0t6ZZECG6xnUrqpvsQsrIbqAXTMX1 D5b56TeexvcrtBb30/VK0zf4Zk89Mfwy6NXKLpw4s/CoVBoNrfMpdjXJX/MsFBAK Qvt2wd5u6KbJrh/+Z+Ve1B6pcoxaCx3O2OJVud34JzWIedtRcI2ZZosCsmQOWAIK H3+7jtZDG6ijOHxJvI9n93V8e7Y8LWdhClTDyWaBbfrqYsV8+/tS72mNWbWHFpE0 xpXWrQ== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 407fg0hmcd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Jul 2024 13:39:28 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 706AB40048; Tue, 9 Jul 2024 13:39:24 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node3.st.com [10.75.129.71]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id BC485223641; Tue, 9 Jul 2024 13:38:58 +0200 (CEST) Received: from [10.48.86.26] (10.48.86.26) by SHFDAG1NODE3.st.com (10.75.129.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.37; Tue, 9 Jul 2024 13:38:58 +0200 Message-ID: Date: Tue, 9 Jul 2024 13:38:41 +0200 Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 47/60] i2c: stm32f4: reword according to newest specification To: Alain Volmat , Wolfram Sang CC: , Andi Shyti , Maxime Coquelin , Alexandre Torgue , , References: <20240706112116.24543-1-wsa+renesas@sang-engineering.com> <20240706112116.24543-48-wsa+renesas@sang-engineering.com> <20240709113216.GA57449@gnbcxd0016.gnb.st.com> Content-Language: en-US From: Pierre Yves MORDRET In-Reply-To: <20240709113216.GA57449@gnbcxd0016.gnb.st.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SHFCAS1NODE2.st.com (10.75.129.73) To SHFDAG1NODE3.st.com (10.75.129.71) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-09_02,2024-07-08_01,2024-05-17_01 Hi All, Look good to me. Regards On 7/9/24 13:32, Alain Volmat wrote: > Hi Wolfram, > > On Sat, Jul 06, 2024 at 01:20:47PM +0200, Wolfram Sang wrote: >> Change the wording of this driver wrt. the newest I2C v7 and SMBus 3.2 >> specifications and replace "master/slave" with more appropriate terms. >> >> Signed-off-by: Wolfram Sang > > Acked-by: Alain Volmat Acked-by: Pierre-Yves MORDRET > >> --- >> drivers/i2c/busses/i2c-stm32f4.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/i2c/busses/i2c-stm32f4.c b/drivers/i2c/busses/i2c-stm32f4.c >> index f8b12be6ef55..230fff0c0bf9 100644 >> --- a/drivers/i2c/busses/i2c-stm32f4.c >> +++ b/drivers/i2c/busses/i2c-stm32f4.c >> @@ -95,7 +95,7 @@ >> >> /** >> * struct stm32f4_i2c_msg - client specific data >> - * @addr: 8-bit slave addr, including r/w bit >> + * @addr: 8-bit target addr, including r/w bit >> * @count: number of bytes to be transferred >> * @buf: data buffer >> * @result: result of the transfer >> @@ -480,7 +480,7 @@ static void stm32f4_i2c_handle_rx_done(struct stm32f4_i2c_dev *i2c_dev) >> >> /** >> * stm32f4_i2c_handle_rx_addr() - Handle address matched interrupt in case of >> - * master receiver >> + * controller receiver >> * @i2c_dev: Controller's private data >> */ >> static void stm32f4_i2c_handle_rx_addr(struct stm32f4_i2c_dev *i2c_dev) >> @@ -643,7 +643,7 @@ static irqreturn_t stm32f4_i2c_isr_error(int irq, void *data) >> >> /* >> * Acknowledge failure: >> - * In master transmitter mode a Stop must be generated by software >> + * In controller transmitter mode a Stop must be generated by software >> */ >> if (status & STM32F4_I2C_SR1_AF) { >> if (!(msg->addr & I2C_M_RD)) { >> @@ -749,7 +749,7 @@ static u32 stm32f4_i2c_func(struct i2c_adapter *adap) >> } >> >> static const struct i2c_algorithm stm32f4_i2c_algo = { >> - .master_xfer = stm32f4_i2c_xfer, >> + .xfer = stm32f4_i2c_xfer, >> .functionality = stm32f4_i2c_func, >> }; >> >> -- >> 2.43.0 >> -- -- ~ Py MORDRET --