From: Hans de Goede <hdegoede@redhat.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Stephen Boyd <sboyd@kernel.org>,
Andy Shevchenko <andy@infradead.org>,
Daniel Scally <djrscally@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Mark Gross <markgross@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
"Rafael J.Wysocki" <rjw@rjwysocki.net>,
Wolfram Sang <wsa@the-dreams.de>, Len Brown <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-i2c <linux-i2c@vger.kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Kate Hsuan <hpa@redhat.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>
Subject: Re: [PATCH v3 05/11] clk: Introduce clk-tps68470 driver
Date: Fri, 22 Oct 2021 11:04:31 +0200 [thread overview]
Message-ID: <fd11b3fb-1f14-cd9e-c6f7-cbea0aa6548b@redhat.com> (raw)
In-Reply-To: <CAHp75Ve_xqgnaCqc3oyDMWDE9kVm8HNOEcdMuDkOD9epwgfWnA@mail.gmail.com>
Hi,
On 10/22/21 10:46, Andy Shevchenko wrote:
> On Thu, Oct 21, 2021 at 8:31 PM Hans de Goede <hdegoede@redhat.com> wrote:
>> On 10/13/21 21:12, Stephen Boyd wrote:
>
> ...
>
>>>> + regmap_write(clkdata->regmap, TPS68470_REG_CLKCFG1,
>
>>>> + (TPS68470_PLL_OUTPUT_ENABLE <<
>>>> + TPS68470_OUTPUT_A_SHIFT) |
>
> One line, please?
>
>>>> + (TPS68470_PLL_OUTPUT_ENABLE <<
>>>> + TPS68470_OUTPUT_B_SHIFT));
>
> Ditto.
Ack, both fixed for v4.
Regards,
Hans
next prev parent reply other threads:[~2021-10-22 9:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-10 18:56 [PATCH v3 00/11] Add support for X86/ACPI camera sensor/PMIC setup with clk and regulator platform data Hans de Goede
2021-10-10 18:56 ` [PATCH v3 01/11] ACPI: delay enumeration of devices with a _DEP pointing to an INT3472 device Hans de Goede
2021-10-11 6:19 ` Mika Westerberg
2021-10-11 7:11 ` Hans de Goede
2021-10-11 9:30 ` Mika Westerberg
2021-10-13 17:29 ` Rafael J. Wysocki
2021-10-13 18:23 ` Hans de Goede
2021-10-13 18:48 ` Rafael J. Wysocki
2021-10-14 15:55 ` Hans de Goede
2021-10-10 18:56 ` [PATCH v3 02/11] i2c: acpi: Use acpi_dev_ready_for_enumeration() helper Hans de Goede
2021-10-11 5:50 ` Wolfram Sang
2021-10-13 17:39 ` Rafael J. Wysocki
2021-10-10 18:56 ` [PATCH v3 03/11] platform_data: Add linux/platform_data/tps68470.h file Hans de Goede
2021-10-10 18:57 ` [PATCH v3 04/11] regulator: Introduce tps68470-regulator driver Hans de Goede
2021-10-10 19:22 ` Randy Dunlap
2021-10-10 18:57 ` [PATCH v3 05/11] clk: Introduce clk-tps68470 driver Hans de Goede
2021-10-10 19:22 ` Randy Dunlap
[not found] ` <163415237957.936110.1269283416777498553@swboyd.mtv.corp.google.com>
2021-10-21 17:31 ` Hans de Goede
2021-10-22 8:46 ` Andy Shevchenko
2021-10-22 9:04 ` Hans de Goede [this message]
2021-10-10 18:57 ` [PATCH v3 06/11] platform/x86: int3472: Enable I2c daisy chain Hans de Goede
2021-10-10 18:57 ` [PATCH v3 07/11] platform/x86: int3472: Split into 2 drivers Hans de Goede
2021-10-10 18:57 ` [PATCH v3 08/11] platform/x86: int3472: Add get_sensor_adev_and_name() helper Hans de Goede
2021-10-10 18:57 ` [PATCH v3 09/11] platform/x86: int3472: Pass tps68470_clk_platform_data to the tps68470-regulator MFD-cell Hans de Goede
2021-10-10 18:57 ` [PATCH v3 10/11] platform/x86: int3472: Pass tps68470_regulator_platform_data " Hans de Goede
2021-10-10 18:57 ` [PATCH v3 11/11] platform/x86: int3472: Deal with probe ordering issues Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd11b3fb-1f14-cd9e-c6f7-cbea0aa6548b@redhat.com \
--to=hdegoede@redhat.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=broonie@kernel.org \
--cc=djrscally@gmail.com \
--cc=hpa@redhat.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lenb@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=mchehab@kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mturquette@baylibre.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sakari.ailus@linux.intel.com \
--cc=sboyd@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).