public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Jae Hyun Yoo <quic_jaehyoo@quicinc.com>
To: Wolfram Sang <wsa@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	"Ingo Molnar" <mingo@redhat.com>,
	Jamie Iles <quic_jiles@quicinc.com>,
	"Graeme Gregory" <quic_ggregory@quicinc.com>,
	<linux-kernel@vger.kernel.org>, <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH v2] i2c: add tracepoints for I2C slave events
Date: Fri, 18 Mar 2022 07:09:32 -0700	[thread overview]
Message-ID: <fdc572ba-2e06-6038-9b02-405860767266@quicinc.com> (raw)
In-Reply-To: <YjRkvPc9uahbozbQ@shikoro>

Hi Wolfram,

On 3/18/2022 3:53 AM, Wolfram Sang wrote:
>> +	if (trace_i2c_slave_enabled() && !ret)
>> +		trace_i2c_slave(client, event, val);
> 
> Why '!ret'? I think we should always print 'ret' in the trace as well.
> Backends are allowed to send errnos on WRITE_RECEIVED to NACK the
> reception of a byte. This is useful information, too, or?

Ah, you are right. As itself should trace all events including NACK
cases, it'd be better to print out the 'ret' too. I'll add it to v3.

Thanks,
Jae

  parent reply	other threads:[~2022-03-18 14:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-08 16:33 [PATCH v2] i2c: add tracepoints for I2C slave events Jae Hyun Yoo
2022-03-18 10:53 ` Wolfram Sang
2022-03-18 13:58   ` Steven Rostedt
2022-03-18 14:09   ` Jae Hyun Yoo [this message]
2022-03-18 14:02 ` Steven Rostedt
2022-03-18 14:14   ` Jae Hyun Yoo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fdc572ba-2e06-6038-9b02-405860767266@quicinc.com \
    --to=quic_jaehyoo@quicinc.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=quic_ggregory@quicinc.com \
    --cc=quic_jiles@quicinc.com \
    --cc=rostedt@goodmis.org \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox