From: Naveen Kaje <nkaje@codeaurora.org>
To: Wolfram Sang <wsa@the-dreams.de>, linux-i2c@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [15/18] i2c: i2c-qup: use new 8 bit address helper function
Date: Thu, 5 May 2016 12:27:20 -0600 [thread overview]
Message-ID: <fdcbf59d-7d26-8151-6858-c73201510f9d@codeaurora.org> (raw)
In-Reply-To: <1459709101-24462-16-git-send-email-wsa@the-dreams.de>
On 4/3/2016 12:44 PM, Wolfram Sang wrote:
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
> drivers/i2c/busses/i2c-qup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c
> index 23eaabb19f961a..cc6439ab3f7141 100644
> --- a/drivers/i2c/busses/i2c-qup.c
> +++ b/drivers/i2c/busses/i2c-qup.c
> @@ -515,7 +515,7 @@ static int qup_i2c_get_data_len(struct qup_i2c_dev *qup)
> static int qup_i2c_set_tags(u8 *tags, struct qup_i2c_dev *qup,
> struct i2c_msg *msg, int is_dma)
> {
> - u16 addr = (msg->addr << 1) | ((msg->flags & I2C_M_RD) == I2C_M_RD);
> + u16 addr = i2c_8bit_addr_from_msg(msg);
> int len = 0;
> int data_len;
Looks good to me. Tested ok on QDF2432.
There is another place in issue_read that we can use this helper
function. I will send a follow up patch.
Reviewed by: Naveen Kaje <nkaje@codeaurora.org>
Tested by: Naveen Kaje <nkaje@codeaurora.org>
>
next prev parent reply other threads:[~2016-05-05 18:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-03 18:44 [PATCH 00/18] i2c: make creation of 8 bit addresses consistent Wolfram Sang
2016-04-03 18:44 ` [PATCH 01/18] i2c: guarantee that I2C_M_RD will be 0x0001 forever Wolfram Sang
2016-04-04 10:26 ` Andy Shevchenko
2016-04-04 10:29 ` Shevchenko, Andriy
2016-04-11 16:54 ` Wolfram Sang
2016-04-04 10:47 ` Wolfram Sang
2016-04-03 18:44 ` [PATCH 02/18] i2c: introduce helper function to get 8 bit address from a message Wolfram Sang
2016-04-03 18:44 ` [PATCH 03/18] i2c: core: use new 8 bit address helper function Wolfram Sang
2016-04-04 10:27 ` Andy Shevchenko
2016-04-03 18:44 ` [PATCH 04/18] i2c: i2c-bcm-iproc: " Wolfram Sang
2016-04-03 18:44 ` [PATCH 05/18] i2c: i2c-bcm-kona: " Wolfram Sang
2016-04-03 18:44 ` [PATCH 06/18] i2c: i2c-brcmstb: " Wolfram Sang
2016-04-03 18:44 ` [PATCH 07/18] i2c: i2c-cpm: " Wolfram Sang
2016-04-03 18:44 ` [PATCH 08/18] i2c: i2c-ibm_iic: " Wolfram Sang
2016-04-03 18:44 ` [PATCH 09/18] i2c: i2c-img-scb: " Wolfram Sang
2016-04-03 18:44 ` [PATCH 10/18] i2c: i2c-iop3xx: " Wolfram Sang
2016-04-03 18:44 ` [PATCH 11/18] i2c: i2c-lpc2k: " Wolfram Sang
2016-04-03 18:44 ` [PATCH 12/18] i2c: i2c-mt65xx: " Wolfram Sang
2016-04-03 18:44 ` [PATCH 13/18] i2c: i2c-ocores: " Wolfram Sang
2016-04-03 18:44 ` [PATCH 14/18] i2c: i2c-powermac: " Wolfram Sang
2016-04-03 18:44 ` [PATCH 15/18] i2c: i2c-qup: " Wolfram Sang
2016-05-05 18:27 ` Naveen Kaje [this message]
2016-04-03 18:44 ` [PATCH 16/18] i2c: i2c-sh_mobile: " Wolfram Sang
2016-04-03 18:45 ` [PATCH 17/18] i2c: i2c-sirf: " Wolfram Sang
2016-04-03 18:45 ` [PATCH 18/18] i2c: i2c-st: " Wolfram Sang
2016-04-04 10:31 ` [PATCH 00/18] i2c: make creation of 8 bit addresses consistent Andy Shevchenko
2016-04-11 17:07 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdcbf59d-7d26-8151-6858-c73201510f9d@codeaurora.org \
--to=nkaje@codeaurora.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).