From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jae Hyun Yoo Subject: Re: [PATCH i2c-next v2] i2c: aspeed: Add an explicit type casting for *get_clk_reg_val Date: Wed, 1 Aug 2018 11:14:35 -0700 Message-ID: References: <20180724203615.5770-1-jae.hyun.yoo@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Brendan Higgins Cc: Benjamin Herrenschmidt , Joel Stanley , Andrew Jeffery , linux-i2c@vger.kernel.org, OpenBMC Maillist , Linux ARM , linux-aspeed@lists.ozlabs.org, Linux Kernel Mailing List , jarkko.nikula@linux.intel.com, james.feist@linux.intel.com, vernon.mauery@linux.intel.com List-Id: linux-i2c@vger.kernel.org On 7/31/2018 11:56 PM, Brendan Higgins wrote: > On Tue, Jul 24, 2018 at 1:39 PM Jae Hyun Yoo > wrote: >> >> This commit fixes this sparse warning: >> drivers/i2c/busses/i2c-aspeed.c:875:38: warning: incorrect type in assignment (different modifiers) >> drivers/i2c/busses/i2c-aspeed.c:875:38: expected unsigned int ( *get_clk_reg_val )( ... ) >> drivers/i2c/busses/i2c-aspeed.c:875:38: got void const *const data >> >> Signed-off-by: Jae Hyun Yoo >> --- >> Changes since v1: >> - Fixed title and added Reported-by tag. >> >> drivers/i2c/busses/i2c-aspeed.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c >> index efb89422d496..a4f956c6d567 100644 >> --- a/drivers/i2c/busses/i2c-aspeed.c >> +++ b/drivers/i2c/busses/i2c-aspeed.c >> @@ -872,7 +872,7 @@ static int aspeed_i2c_probe_bus(struct platform_device *pdev) >> if (!match) >> bus->get_clk_reg_val = aspeed_i2c_24xx_get_clk_reg_val; >> else >> - bus->get_clk_reg_val = match->data; >> + bus->get_clk_reg_val = (u32 (*)(u32))match->data; >> >> /* Initialize the I2C adapter */ >> spin_lock_init(&bus->lock); >> -- >> 2.18.0 >> > > Reviewed-by: Brendan Higgins > Thanks a lot Brendan for your review! Hi Wolfram, I forgot adding 'Reported-by: Wolfram Sang '. Please add this tag when you apply this patch, or let me know if I need to submit v3 for adding the tag. Thanks, Jae