From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kieran Bingham Subject: Re: [PATCH v1 15/15] media: i2c: adv748x: Remove duplicate NULL check Date: Fri, 3 Nov 2017 23:41:25 +0000 Message-ID: References: <20171031142149.32512-1-andriy.shevchenko@linux.intel.com> <20171031142149.32512-15-andriy.shevchenko@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20171031142149.32512-15-andriy.shevchenko@linux.intel.com> Content-Language: en-GB Sender: linux-media-owner@vger.kernel.org To: Andy Shevchenko , linux-i2c@vger.kernel.org, Wolfram Sang Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org List-Id: linux-i2c@vger.kernel.org Hi Andy, Thankyou for the patch. On 31/10/17 14:21, Andy Shevchenko wrote: > Since i2c_unregister_device() became NULL-aware we may remove duplicate > NULL check. > > Cc: Kieran Bingham > Cc: Mauro Carvalho Chehab > Cc: linux-media@vger.kernel.org > Signed-off-by: Andy Shevchenko Acked-by: Kieran Bingham > --- > drivers/media/i2c/adv748x/adv748x-core.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c > index 5ee14f2c2747..10c3d469175c 100644 > --- a/drivers/media/i2c/adv748x/adv748x-core.c > +++ b/drivers/media/i2c/adv748x/adv748x-core.c > @@ -225,10 +225,8 @@ static void adv748x_unregister_clients(struct adv748x_state *state) > { > unsigned int i; > > - for (i = 1; i < ARRAY_SIZE(state->i2c_clients); ++i) { > - if (state->i2c_clients[i]) > - i2c_unregister_device(state->i2c_clients[i]); > - } > + for (i = 1; i < ARRAY_SIZE(state->i2c_clients); ++i) > + i2c_unregister_device(state->i2c_clients[i]); > } > > static int adv748x_initialise_clients(struct adv748x_state *state) >