From: Javier Martinez Canillas <javierm@redhat.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-kernel@vger.kernel.org, Simon Horman <horms@verge.net.au>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-i2c@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH v6] eeprom: at24: Add OF device ID table
Date: Mon, 6 Nov 2017 10:13:45 +0100 [thread overview]
Message-ID: <fec1c0d1-425d-542e-bb6c-402b47b46ceb@redhat.com> (raw)
In-Reply-To: <20171105215344.a5nyk7xmcdl22tpd@ninjato>
Hello Wolfram,
On 11/05/2017 10:53 PM, Wolfram Sang wrote:
> On Sun, Oct 01, 2017 at 12:49:48PM +0200, Javier Martinez Canillas wrote:
>> The driver doesn't have a struct of_device_id table but supported devices
>> are registered via Device Trees. This is working on the assumption that a
>> I2C device registered via OF will always match a legacy I2C device ID and
>> that the MODALIAS reported will always be of the form i2c:<device>.
>>
>> But this could change in the future so the correct approach is to have an
>> OF device ID table if the devices are registered via OF.
>>
>> To maintain backward compatibility with old Device Trees, only use the OF
>> device ID table .data if the device was registered via OF and the OF node
>> compatible matches an entry in the OF device ID table.
>>
>> Suggested-by: Wolfram Sang <wsa@the-dreams.de>
>> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
>>
>
> Applied to for-next, thanks for keeping at it!
>
Great, thanks a lot for your feedback and suggestions on this series.
Best regards,
--
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat
prev parent reply other threads:[~2017-11-06 9:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-01 10:49 [PATCH v6] eeprom: at24: Add OF device ID table Javier Martinez Canillas
2017-10-17 21:40 ` Wolfram Sang
2017-10-17 21:43 ` Rob Herring
2017-10-17 21:47 ` Wolfram Sang
2017-10-18 6:39 ` Geert Uytterhoeven
2017-10-18 18:51 ` Javier Martinez Canillas
2017-11-05 21:53 ` Wolfram Sang
2017-11-06 9:13 ` Javier Martinez Canillas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fec1c0d1-425d-542e-bb6c-402b47b46ceb@redhat.com \
--to=javierm@redhat.com \
--cc=andy.shevchenko@gmail.com \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).