From: LakshmiPraveen Kopparthi <LakshmiPraveen.Kopparthi@microchip.com>
To: Dmitry Osipenko <digetx@gmail.com>, <wsa@kernel.org>,
<andriy.shevchenko@linux.intel.com>, <treding@nvidia.com>,
<mirq-linux@rere.qmqm.pl>, <s.shtylyov@omp.ru>,
<linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH v1 1/2] i2c:busses:Register PCI1XXXX adapter to I2C subsystem
Date: Tue, 5 Oct 2021 14:19:48 +0530 [thread overview]
Message-ID: <fec61302f82d5030976ae9026619198580b8d53a.camel@microchip.com> (raw)
In-Reply-To: <775e00e3-e204-7138-9648-7551098968b8@gmail.com>
On Wed, 2021-09-29 at 17:35 +0300, Dmitry Osipenko wrote:
> [Some people who received this message don't often get email from
> digetx@gmail.com. Learn why this is important at
> http://aka.ms/LearnAboutSenderIdentification.]
>
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
>
> 29.09.2021 10:18, Dmitry Osipenko пишет:
> > +static void pci1xxxx_i2c_remove_pci(struct pci_dev *pdev)
> > +{
> > + struct pci1xxxx_i2c *i2c = pci_get_drvdata(pdev);
> > +
> > + pci1xxxx_i2c_shutdown(i2c);
> > + i2c_del_adapter(&i2c->adap);
>
> The order is wrong. Adapter must be removed first, then hardware can
> be
> disabled.
ok. Got it. Will change it.
>
> > +}
next prev parent reply other threads:[~2021-10-05 8:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 6:22 [PATCH v1 0/2] i2c:busses:Microchip PCI1XXXX I2C adapter LakshmiPraveen Kopparthi
2021-09-29 6:22 ` [PATCH v1 1/2] i2c:busses:Register PCI1XXXX adapter to I2C subsystem LakshmiPraveen Kopparthi
2021-09-29 7:18 ` Dmitry Osipenko
2021-09-29 14:35 ` Dmitry Osipenko
2021-10-05 8:49 ` LakshmiPraveen Kopparthi [this message]
2021-09-29 16:44 ` Andy Shevchenko
2021-10-05 8:49 ` LakshmiPraveen Kopparthi
2021-10-05 8:50 ` LakshmiPraveen Kopparthi
2021-10-07 16:24 ` Dmitry Osipenko
2021-10-07 16:33 ` Andy Shevchenko
2021-10-07 16:30 ` Dmitry Osipenko
2021-09-29 17:12 ` Michał Mirosław
2021-10-08 6:22 ` LakshmiPraveen Kopparthi
2021-10-07 16:40 ` Dmitry Osipenko
2021-10-07 17:05 ` Andy Shevchenko
2021-09-29 6:22 ` [PATCH v1 2/2] i2c:busses:Read and Write routines for PCI1XXXX I2C module LakshmiPraveen Kopparthi
2021-09-29 7:20 ` Dmitry Osipenko
2021-10-05 8:48 ` LakshmiPraveen Kopparthi
2021-10-07 16:15 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fec61302f82d5030976ae9026619198580b8d53a.camel@microchip.com \
--to=lakshmipraveen.kopparthi@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=digetx@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=s.shtylyov@omp.ru \
--cc=treding@nvidia.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).