From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
sedat.dilek@credativ.de, Jean Delvare <jdelvare@suse.de>,
linux-i2c@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Paul Mackerras <pmac@au1.ibm.com>
Subject: Re: [PATCH v2] i2c: Remove '-Wno-deprecated-declarations' compiler warning
Date: Mon, 20 Aug 2018 21:25:24 +1000 [thread overview]
Message-ID: <fed6012f3438f996cd2e7cb62e8eee58964fa36c.camel@kernel.crashing.org> (raw)
In-Reply-To: <20180820080629.i7y4cx4wewmcyqpk@ninjato>
On Mon, 2018-08-20 at 10:06 +0200, Wolfram Sang wrote:
>
> > Some people still use those old machines, I'll give a try at fixing the
> > driver.
>
> I did this here a while ago [1] ("macintosh: therm_windtunnel: drop
> using attach adapter")...
>
> > Paul: Do you still have one of these machines ?
>
> ... but this was the main problem. I couldn't find anyone to test this.
> Even asked on PPC lists of various distributions.
Yeah this one is annoying because it's only used by one specific
machine model..
> Note that we did apply the same approach of patch [1] already in commit
> ac397c80de89 ("ALSA: ppc: keywest: drop using attach adapter"). This has
> been tested on HW. I also have a hack to make this driver probe on one
> of my ARM boards. Of course, no real HW present there, but shows that
> the new probing works at least there.
>
> This is very interesting timing, too. Because I wanted to use the
> tentative version jump to 5.0 to finally get rid of this deprecated
> feature independently of the discussion here. Which would have meant
> resending the patch and arguing we have enough indications that the
> patch [1] is sane. And then I could finally remove this callback.
>
> Thanks,
>
> Wolfram
>
> [1] http://patchwork.ozlabs.org/patch/461759/
Ok, worst case we can remove the driver and re-instate it back later if
somebody complains, but I'll try to chase a machine first.
Cheers,
Ben.
next prev parent reply other threads:[~2018-08-20 11:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-19 13:51 [PATCH v2] i2c: Remove '-Wno-deprecated-declarations' compiler warning Sedat Dilek
2018-08-19 15:23 ` kbuild test robot
2018-08-19 16:46 ` Linus Torvalds
2018-08-20 2:12 ` Benjamin Herrenschmidt
2018-08-20 8:06 ` Wolfram Sang
2018-08-20 11:25 ` Benjamin Herrenschmidt [this message]
2018-08-20 20:36 ` Linus Torvalds
2018-08-21 2:04 ` Wolfram Sang
2018-08-24 13:01 ` Wolfram Sang
2018-08-24 13:49 ` Sedat Dilek
2018-08-24 14:07 ` Wolfram Sang
2018-08-24 14:19 ` Sedat Dilek
2018-08-24 15:01 ` Wolfram Sang
2018-08-24 15:03 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fed6012f3438f996cd2e7cb62e8eee58964fa36c.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ndesaulniers@google.com \
--cc=pmac@au1.ibm.com \
--cc=sedat.dilek@credativ.de \
--cc=torvalds@linux-foundation.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).