From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Sergey Shtylyov <s.shtylyov@omprussia.ru>,
<linux-i2c@vger.kernel.org>, Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH0/2] Fix deferred probing in the I2C bus drivers
Date: Sun, 30 May 2021 18:53:35 +0300 [thread overview]
Message-ID: <ff61c075-f844-8108-0686-69a0cb925627@omp.ru> (raw)
In-Reply-To: <eda766e5-3ce3-81ec-52b4-df75297b9941@omp.ru>
On 5/28/21 11:57 PM, Sergey Shtylyov wrote:
[...]
>> Here are 2 patches against the 'i2c/for-current' branch of Wolfram's 'linux.git' repo.
>> The affected drivers call platform_get_irq() but override its result in case of error
>> which prevents the deferred probing from working.
>>
>> [1/2] i2c: iop3xx: fix deferred probing
>> [2/2] i2c: synquacer: fix deferred probing
>
> Please hold on with this series; I'm gonna add another patch...
Actually, I'm unsure about drivers/i2c/busses/i2c-pca-platform.c: normally it
uses polling iff the (considered optional) IRQ can't be set up (irq < 0 returned
from platform_get_irq_optional()) then polling mode is used. I have a patch to
propaate -EPROBE_DEFER upstream but I'm not sure what is better : sefer the probe
(and potentially falling permanently iff the kernel wouldn't able to finally set
up the IRQ or to start the I2C driver in the polling mode right away. Does these
doubts even make sense? :-)
MBR, Sergey
next prev parent reply other threads:[~2021-05-30 15:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-17 20:57 [PATCH0/2] Fix deferred probing in the I2C bus drivers Sergey Shtylyov
2021-04-17 20:58 ` [PATCH 1/2] i2c: iop3xx: fix deferred probing Sergey Shtylyov
2021-04-17 20:59 ` [PATCH 2/2] i2c: synquacer: " Sergey Shtylyov
2021-05-28 20:57 ` [PATCH0/2] Fix deferred probing in the I2C bus drivers Sergey Shtylyov
2021-05-30 15:53 ` Sergey Shtylyov [this message]
2021-05-30 16:01 ` Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff61c075-f844-8108-0686-69a0cb925627@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=ardb@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=s.shtylyov@omprussia.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox