From mboxrd@z Thu Jan 1 00:00:00 1970 From: Darius Subject: Re: [PATCH V5] I2C bus driver for IMX Date: Tue, 20 May 2008 09:39:53 +0300 Message-ID: References: <20080514213214.GB16881@fluff.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: i2c-bounces-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org Errors-To: i2c-bounces-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org To: i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org Cc: linux-arm-kernel-xIg/pKzrS19vn6HldHNs0ANdhmdF6hFW@public.gmane.org List-Id: linux-i2c@vger.kernel.org > Also lets you do some > sort of macro: > #define dprintk(dev, fmt, args...) dev_dbg(dev, "<%s> " fmt, __func__, ## args) > or > #define dprintk(fmt, args...) dev_dbg(&i2c_imx->adapter.dev, "<%s> " fmt, __func__, ## args) Thank you (and all others) for all comments and for help writing this driver. Regarding such macros, I think it is pointless. Because there is opinion, that all kernel drivers should look similar, and dev_dbg() is used in most drivers. It is macro itself, therefore I think in the future would be easier to read and debug this driver with standard debug macro. BR, Darius _______________________________________________ i2c mailing list i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org http://lists.lm-sensors.org/mailman/listinfo/i2c