From: Eudean Sun <eudean-BGArkANP9klv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] i2c-i801: utilize hardware semaphore
Date: Fri, 2 Nov 2012 00:01:38 +0000 (UTC) [thread overview]
Message-ID: <loom.20121102T005401-899@post.gmane.org> (raw)
In-Reply-To: 489e78bb-0678-4593-9888-70a8667d8cda@zimbra
Aaron Sierra <asierra@...> writes:
>
> The i2c-i801 driver (along with 12 others) was modified to include a check
> for ACPI resource conflicts by the following commit prior to 2.6.27
> release:
>
> commit 54fb4a05af0a4b814e6716cfdf3fa97fc6be7a32
> i2c: Check for ACPI resource conflicts
>
Thanks for posting this Aaron.
> + if (status & SMBHSTSTS_INUSE_STS) {
> + dev_err(&priv->pci_dev->dev, "SMBus is in use, can't use it!\n");
> + return -EBUSY;
> + }
> +
> + return 0;
> +}
Noticed there are spaces rather than tabs indenting the return 0 above. Looks
good otherwise.
Eudean
next prev parent reply other threads:[~2012-11-02 0:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <12c67a1f-9634-4fd7-bce8-bcb661cb3064@zimbra>
2012-10-31 20:06 ` [PATCH] i2c-i801: utilize hardware semaphore Aaron Sierra
2012-11-02 0:01 ` Eudean Sun [this message]
[not found] <4fdceda1-2fee-4c8e-a15b-5e1e62c0d82b@zimbra>
2012-01-26 21:53 ` Aaron Sierra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20121102T005401-899@post.gmane.org \
--to=eudean-bgarkanp9klv6pq1l3v1odbpr1lh4cv8@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).