From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grazvydas Ignotas Subject: Re: [PATCH] i2c: omap: fix OOPS in omap_i2c_unidle() during probe Date: Fri, 16 Apr 2010 12:47:50 +0300 Message-ID: References: <1269339176-17479-1-git-send-email-ext-mika.1.westerberg@nokia.com> <20100331152700.17695375.jhnikula@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20100331152700.17695375.jhnikula@gmail.com> Sender: linux-omap-owner@vger.kernel.org To: "Ben Dooks (embedded platforms)" Cc: Paul Walmsley , Mika Westerberg , linux-i2c@vger.kernel.org, linux-omap@vger.kernel.org, Cory Maccarrone , Jarkko Nikula , Jean Delvare , Tony Lindgren List-Id: linux-i2c@vger.kernel.org On Wed, Mar 31, 2010 at 3:27 PM, Jarkko Nikula wro= te: > On Wed, 31 Mar 2010 04:27:41 -0600 (MDT) > Paul Walmsley wrote: > >> > This patch moves register shift setting before any register access= es are done. >> > >> > Signed-off-by: Mika Westerberg >> > Cc: Cory Maccarrone >> >> Tested-by: Paul Walmsley >> > BTW, Tony had the same fix buried in an another thread: > > http://marc.info/?l=3Dlinux-omap&m=3D126826012627677&w=3D2 > > You could add my tested by as well to which one goes in but the fix > should go for 2.6.34 as the mainline doesn't boot otherwise on OMAP. Uhm why does this patch (or Tony's version) doesn't reach mainline for so long? It's critical for all OMAPs except the very old ones. If it helps: Tested-by: Grazvydas Ignotas > > Tested-by: Jarkko Nikula > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap"= in > the body of a message to majordomo@vger.kernel.org > More majordomo info at =A0http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html