From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Peter Yin <peteryin.openbmc@gmail.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Frank Li <Frank.Li@nxp.com>,
linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] i3c: master: ast2600: Fix missing of_node for virtual I2C adapter
Date: Wed, 25 Feb 2026 14:43:17 +0800 [thread overview]
Message-ID: <0307499b99c3ea9280ea2d6b9c3e325aeec46a0d.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20260225063529.3230676-1-peteryin.openbmc@gmail.com>
Hi Peter,
> The ASPEED AST2600 I3C master driver creates a virtual I2C adapter to
> provide backward compatibility with I2C devices. However, the current
> implementation does not associate this virtual adapter with any
> Device Tree node.
>
> This patch propagates the of_node from the I3C master platform device
> to the virtual I2C adapter's device structure. This ensures that
> standard I2C aliases are correctly resolved and bus numbering remains
> consistent across reboots.
Sounds sensible - but:
> --- a/drivers/i3c/master/ast2600-i3c-master.c
> +++ b/drivers/i3c/master/ast2600-i3c-master.c
> @@ -156,6 +156,7 @@ static int ast2600_i3c_probe(struct platform_device *pdev)
> i3c->sda_pullup);
>
> i3c->dw.platform_ops = &ast2600_i3c_ops;
> + i3c->dw.base.i2c.dev.of_node = np;
> return dw_i3c_common_probe(&i3c->dw, pdev);
> }
Why not do this in the common (dw) driver? Nothing about the of_node
association is aspeed-specific.
Cheers,
Jeremy
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2026-02-25 6:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 6:35 [PATCH v1] i3c: master: ast2600: Fix missing of_node for virtual I2C adapter Peter Yin
2026-02-25 6:43 ` Jeremy Kerr [this message]
2026-02-25 9:19 ` Peter Yin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0307499b99c3ea9280ea2d6b9c3e325aeec46a0d.camel@codeconstruct.com.au \
--to=jk@codeconstruct.com.au \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peteryin.openbmc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox