From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Guruvendra Punugupati <Guruvendra.Punugupati@amd.com>,
Krishnamoorthi M <krishnamoorthi.m@amd.com>,
linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/5] i3c: mipi-i3c-hci: Add a quirk to set PIO mode
Date: Tue, 6 Aug 2024 10:09:28 +0300 [thread overview]
Message-ID: <034b5511-e3c2-443d-8bac-8e5ed7095236@linux.intel.com> (raw)
In-Reply-To: <8ec23c64-0b55-4a71-8199-14cb6061ad45@amd.com>
On 8/5/24 12:26 PM, Shyam Sundar S K wrote:
> Hi,
>
> On 8/2/2024 19:28, Jarkko Nikula wrote:
>>
>> This is true, I see this now from pre-v1.0, v1.0. v1.1 and v1.2 specs
>> too, HC_CONTROL_PIO_MODE bit is present only after v1.0. And therefore
>> version != HCI_VERSION_V1 check is not fully correct since bit is not
>> present in pre-v1.0 HW versions either.
>>
>
> Agreed. HC_CONTROL_PIO_MODE is only present in v1.1 and v1.2.
>
> anything below v1.0, the version check handling is already present;
>
> switch (regval & ~0xf) {
> case 0x100: /* version 1.0 */
> case 0x110: /* version 1.1 */
> case 0x200: /* version 2.0 */
> break;
> default:
> dev_err(&hci->master.dev, "unsupported HCI version\n");
> return -EPROTONOSUPPORT;
> }
>
> Let me know your thoughts.
>
Yeah, true. I'd still use version > v1.0 check because that reflects the
current situation. Mostly to avoid confusion when reading the code but
also if someone adds support for pre-v1.0 HW (perhaps unlikely) and then
doesn't need to change version check here.
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2024-08-06 7:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-24 7:12 [PATCH v2 0/5] Introduce initial AMD I3C HCI driver support Shyam Sundar S K
2024-07-24 7:12 ` [PATCH v2 1/5] i3c: mipi-i3c-hci: Add MIPI0100 ACPI ID to the I3C Support List Shyam Sundar S K
2024-08-02 13:23 ` Jarkko Nikula
2024-07-24 7:12 ` [PATCH v2 2/5] i3c: mipi-i3c-hci: Add a quirk to set PIO mode Shyam Sundar S K
2024-08-02 13:58 ` Jarkko Nikula
2024-08-05 9:26 ` Shyam Sundar S K
2024-08-06 7:09 ` Jarkko Nikula [this message]
2024-07-24 7:12 ` [PATCH v2 3/5] i3c: mipi-i3c-hci: Relocate helper macros to HCI header file Shyam Sundar S K
2024-07-24 7:12 ` [PATCH v2 4/5] i3c: mipi-i3c-hci: Add a quirk to set timing parameters Shyam Sundar S K
2024-07-24 7:12 ` [PATCH v2 5/5] i3c: mipi-i3c-hci: Add a quirk to set Response buffer threshold Shyam Sundar S K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=034b5511-e3c2-443d-8bac-8e5ed7095236@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=Guruvendra.Punugupati@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=alexandre.belloni@bootlin.com \
--cc=krishnamoorthi.m@amd.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox