From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02A4BC06519 for ; Thu, 4 Jul 2019 09:56:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CEFCE21882 for ; Thu, 4 Jul 2019 09:56:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kcgKFlOD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CEFCE21882 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=epFWHJkCc15C16+jNtgGbYabxZzyZZMD04T8j6TR94s=; b=kcgKFlODiAIwkK Szqdy63c/ypjcgAwwrb/4QahT3cjJDl1cj6C64y0A/Vn3YCYRmmE03hQXZ1t11/e/H6FbHa8Be0jX BWRkScACX4Y0mT50do/eyEod0525HNtzXGqF7rLt8wLYf+hM74Inr68mb71DVJBJM6oNvFrf1mrFn 7jUHWuQc6HYQvligCxAy7BJBSGgHV8INmUC9Buo1pA11wtGSzpoLaRdrykMr+g0uCZF7StLSuz9r5 jfaffenHEqSQVm3EEMoF2Xp5WQyBCTeh1QZSxEuUCHJ+oQyFUJT8qzuGqz9UdW7ePikZQ16vQpvfO /+A2otwbw7BCvYUme4Bg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hiyTl-0007uj-H5; Thu, 04 Jul 2019 09:56:37 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hgOmz-00080i-2n; Thu, 27 Jun 2019 07:25:50 +0000 X-UUID: 6535ad019e8341bab7b5ff41e81c64a2-20190626 X-UUID: 6535ad019e8341bab7b5ff41e81c64a2-20190626 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1214892574; Wed, 26 Jun 2019 23:25:31 -0800 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 27 Jun 2019 00:25:30 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 27 Jun 2019 15:25:27 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 27 Jun 2019 15:25:27 +0800 Message-ID: <1561620327.12217.27.camel@mhfsdcap03> Subject: Re: [PATCH v2 1/2] dt-bindings: i3c: Document MediaTek I3C master bindings From: Qii Wang To: Boris Brezillon Date: Thu, 27 Jun 2019 15:25:27 +0800 In-Reply-To: <20190626182339.0c6301a2@collabora.com> References: <1561527388-4829-1-git-send-email-qii.wang@mediatek.com> <1561527388-4829-2-git-send-email-qii.wang@mediatek.com> <20190626182339.0c6301a2@collabora.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190627_002549_133007_E5AE8E99 X-CRM114-Status: GOOD ( 19.67 ) X-Mailman-Approved-At: Thu, 04 Jul 2019 02:56:35 -0700 X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux I3C List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, srv_heupstream@mediatek.com, bbrezillon@kernel.org, leilk.liu@mediatek.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, liguo.zhang@mediatek.com, linux-mediatek@lists.infradead.org, xinping.qian@mediatek.com, matthias.bgg@gmail.com, linux-i3c@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org On Wed, 2019-06-26 at 18:23 +0200, Boris Brezillon wrote: > On Wed, 26 Jun 2019 13:36:27 +0800 > Qii Wang wrote: > > > Document MediaTek I3C master DT bindings. > > > > Signed-off-by: Qii Wang > > --- > > .../devicetree/bindings/i3c/mtk,i3c-master.txt | 47 ++++++++++++++++++++ > > 1 file changed, 47 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/i3c/mtk,i3c-master.txt > > > > diff --git a/Documentation/devicetree/bindings/i3c/mtk,i3c-master.txt b/Documentation/devicetree/bindings/i3c/mtk,i3c-master.txt > > new file mode 100644 > > index 0000000..3fd4f17 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/i3c/mtk,i3c-master.txt > > @@ -0,0 +1,47 @@ > > +Bindings for MediaTek I3C master block > > +===================================== > > + > > +Required properties: > > +-------------------- > > +- compatible: shall be "mediatek,i3c-master" > > +- reg: physical base address of the controller and apdma base, length of > > + memory mapped region. > > +- reg-names: should be "main" for controller and "dma" for apdma. > > +- interrupts: interrupt number to the cpu. > > Depending on the interrupt controller, each interrupt cell might > contain more than just the interrupt number. > ok, I will modify it as "the interrupt line connected to this I3C master" > > +- clocks: clock name from clock manager. > > This property does not contain clock names but clk references. > ok, I will modify it as "shall reference the i3c and apdma clocks" > > +- clock-names: must include "main" and "dma". > > + > > +Mandatory properties defined by the generic binding (see > > +Documentation/devicetree/bindings/i3c/i3c.txt for more details): > > + > > +- #address-cells: shall be set to 3 > > +- #size-cells: shall be set to 0 > > + > > +Optional properties defined by the generic binding (see > > +Documentation/devicetree/bindings/i3c/i3c.txt for more details): > > + > > +- i2c-scl-hz > > +- i3c-scl-hz > > + > > +I3C device connected on the bus follow the generic description (see > > +Documentation/devicetree/bindings/i3c/i3c.txt for more details). > > + > > +Example: > > + > > + i3c0: i3c@1100d000 { > > + compatible = "mediatek,i3c-master"; > > + reg = <0x1100d000 0x100>, > > + <0x11000300 0x80>; > > + reg-names = "main", "dma"; > > + interrupts = ; > > + clocks = <&i3c0_ck>, <&ap_dma_ck>; > > + clock-names = "main", "dma"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + i2c-scl-hz = <100000>; > > + > > + nunchuk: nunchuk@52 { > > + compatible = "nintendo,nunchuk"; > > + reg = <0x52 0x80000010 0>; > > reg is wrong here, should be > > reg = <0x52 0x0 0x10>; > > While at it, can you send a patch to fix the example in the cadence > binding doc? > ok, I will do it. Thanks for your review. > > + }; > > + }; > _______________________________________________ linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c