public inbox for linux-i3c@lists.infradead.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: conor.culhane@silvaco.com, linux-serial@vger.kernel.org,
	 zbigniew.lukwinski@linux.intel.com, joe@perches.com,
	imx@lists.linux.dev,  linux-kernel@vger.kernel.org,
	linux-i3c@lists.infradead.org,  frank.li@nxp.com,
	devicetree@vger.kernel.org, miquel.raynal@bootlin.com,
	 alexandre.belloni@bootlin.com, gregkh@linuxfoundation.org,
	 jirislaby@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	 krzysztof.kozlowski@linaro.org
Subject: Re: [PATCH v3 2/8] dt-bindings: i3c: svc: add proptery mode
Date: Tue, 23 Jan 2024 16:38:20 -0600	[thread overview]
Message-ID: <170604949961.2185792.3557017002643301182.robh@kernel.org> (raw)
In-Reply-To: <20240123212549.3858137-3-Frank.Li@nxp.com>


On Tue, 23 Jan 2024 16:25:43 -0500, Frank Li wrote:
> Add proptery 'mode' to distinguish work at 'controller' or 'target' mode.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> 
> Notes:
>     Change from v2 to v3
>         - using 'mode' distringuish master and target mode
> 
>  .../devicetree/bindings/i3c/silvaco,i3c-master.yaml   | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml:26:4: [warning] wrong indentation: expected 4 but found 3 (indentation)
./Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml:30:9: [error] syntax error: mapping values are not allowed here (syntax)

dtschema/dtc warnings/errors:
make[2]: *** Deleting file 'Documentation/devicetree/bindings/i3c/silvaco,i3c-master.example.dts'
Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml:30:9: mapping values are not allowed in this context
make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/i3c/silvaco,i3c-master.example.dts] Error 1
make[2]: *** Waiting for unfinished jobs....
./Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml:30:9: mapping values are not allowed in this context
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml: ignoring, error parsing file
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1428: dt_binding_check] Error 2
make: *** [Makefile:240: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240123212549.3858137-3-Frank.Li@nxp.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

  reply	other threads:[~2024-01-23 22:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-23 21:25 [PATCH v3 0/8] I3C target mode support Frank Li
2024-01-23 21:25 ` [PATCH v3 1/8] i3c: add " Frank Li
2024-01-23 21:25 ` [PATCH v3 2/8] dt-bindings: i3c: svc: add proptery mode Frank Li
2024-01-23 22:38   ` Rob Herring [this message]
2024-01-23 21:25 ` [PATCH v3 3/8] Documentation: i3c: Add I3C target mode controller and function Frank Li
2024-01-23 21:25 ` [PATCH v3 4/8] i3c: svc: Add svc-i3c-main.c and svc-i3c.h Frank Li
2024-01-23 21:25 ` [PATCH v3 5/8] i3c: target: add svc target controller support Frank Li
2024-01-23 21:25 ` [PATCH v3 6/8] i3c: target: func: add tty driver Frank Li
2024-01-23 21:25 ` [PATCH v3 7/8] i3c: add API i3c_dev_gettstatus_format1() to get target device status Frank Li
2024-01-23 21:25 ` [PATCH v3 8/8] tty: i3c: add TTY over I3C master support Frank Li
2024-01-23 23:12 ` [PATCH v3 0/8] I3C target mode support Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170604949961.2185792.3557017002643301182.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Frank.Li@nxp.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=conor.culhane@silvaco.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=imx@lists.linux.dev \
    --cc=jirislaby@kernel.org \
    --cc=joe@perches.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-i3c@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=zbigniew.lukwinski@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox